Migrate upgrade notifications to observer

chrome/browser/upgrade_detector.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UPGRADE_DETECTOR_H_
 #define CHROME_BROWSER_UPGRADE_DETECTOR_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/observer_list.h"
 #include "base/timer/timer.h"
-#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/upgrade_observer.h"
 #include "ui/base/idle/idle.h"
 #include "ui/gfx/image/image.h"
 
 class PrefRegistrySimple;
 class UpgradeObserver;
 
 ///////////////////////////////////////////////////////////////////////////////
 // UpgradeDetector
 //
@@ skipping 56 matching lines @@
   gfx::Image GetIcon();
 
   UpgradeNotificationAnnoyanceLevel upgrade_notification_stage() const {
     return upgrade_notification_stage_;
   }
 
   void AddObserver(UpgradeObserver* observer);
 
   void RemoveObserver(UpgradeObserver* observer);
 
+  // Notifies that the current install is outdated. No details are expected.
+  void NotifyOutdatedInstall();

[sky, 2017/06/07 23:01:42]

Why do the notify functions need to be public?

[weidongg, 2017/06/08 02:28:42]

browser_commands.cc needs to notify upgrade to the observers. Should I make them
protected and add BrowserCommand as a friend class?

+
+  // Notifies that the current install is outdated and auto-update (AU) is

[sky, 2017/06/07 23:01:42]

I realize it's long, but go with AutoUpdate. au is cryptic.

[weidongg, 2017/06/08 02:28:42]

Done.

+  // disabled. No details are expected.
+  void NotifyOutdatedInstallNoAU();
+
  protected:
   enum UpgradeAvailable {
     // If no update is available and current install is recent enough.
     UPGRADE_AVAILABLE_NONE,
     // If a regular update is available.
     UPGRADE_AVAILABLE_REGULAR,
     // If a critical update to Chrome has been installed, such as a zero-day
     // fix.
     UPGRADE_AVAILABLE_CRITICAL,
     // If no update to Chrome has been installed for more than the recommended
     // time.
     UPGRADE_NEEDED_OUTDATED_INSTALL,
     // If no update to Chrome has been installed for more than the recommended
     // time AND auto-update is turned off.
     UPGRADE_NEEDED_OUTDATED_INSTALL_NO_AU,
   };
 
   UpgradeDetector();
 
-  // Sends out UPGRADE_RECOMMENDED notification and set notify_upgrade_.
+  // Notifies that update is recommended and triggers different actions based
+  // on the update availability.
+  void NotifyUpgrade();
+
+  // Notifies that update is recommended.
   void NotifyUpgradeRecommended();
 
+  // Notifies that a critical update has been installed. No details are
+  // expected.
+  void NotifyCriticalUpgradeInstalled();
+
   // The function that sends out a notification that lets the rest of the UI
   // know we should notify the user that a new update is available to download
   // over cellular connection.
   void NotifyUpdateOverCellularAvailable();
 
   // Triggers a critical update, which starts a timer that checks the machine
   // idle state. Protected and virtual so that it could be overridden by tests.
   virtual void TriggerCriticalUpdate();
 
   UpgradeAvailable upgrade_available() const { return upgrade_available_; }
@@ skipping 28 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AppMenuModelTest, Basics);
   FRIEND_TEST_ALL_PREFIXES(SystemTrayClientTest, UpdateTrayIcon);
 
   // Initiates an Idle check. See IdleCallback below.
   void CheckIdle();
 
   // The callback for the IdleCheck. Tells us whether Chrome has received any
   // input events since the specified time.
   void IdleCallback(ui::IdleState state);
 
-  // Triggers a global notification of the specified |type|.
-  void TriggerNotification(chrome::NotificationType type);
-
   // Whether any software updates are available (experiment updates are tracked
   // separately via additional member variables below).
   UpgradeAvailable upgrade_available_;
 
   // Whether "best effort" experiment updates are available.
   bool best_effort_experiment_updates_available_;
 
   // Whether "critical" experiment updates are available.
   bool critical_experiment_updates_available_;
 
@@ skipping 14 matching lines @@
   // Whether we have waited long enough after detecting an upgrade (to see
   // is we should start nagging about upgrading).
   bool notify_upgrade_;
 
   base::ObserverList<UpgradeObserver> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(UpgradeDetector);
 };
 
 #endif  // CHROME_BROWSER_UPGRADE_DETECTOR_H_