Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292593002: Experimental flag to enable Google Cloud Devices features. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Experimental flag to enable Google Cloud Devices features. BUG=374349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271255

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fri 05/16/2014 15:16:53.43 #

Total comments: 2

Patch Set 3 : Fri 05/16/2014 15:19:49.41 #

Patch Set 4 : Fri 05/16/2014 15:24:06.02 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 2 chunks +11 lines, -3 lines 0 comments Download
M components/cloud_devices/common/cloud_devices_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/cloud_devices/common/cloud_devices_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-16 22:16:07 UTC) #1
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/292593002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/292593002/diff/1/chrome/browser/about_flags.cc#newcode1341 chrome/browser/about_flags.cc:1341: kOsDesktop, Is this OK to include Mac here?
6 years, 7 months ago (2014-05-16 22:17:50 UTC) #2
Noam Samuel
On 2014/05/16 22:17:50, Vitaly Buka wrote: > https://codereview.chromium.org/292593002/diff/1/chrome/browser/about_flags.cc > File chrome/browser/about_flags.cc (right): > > https://codereview.chromium.org/292593002/diff/1/chrome/browser/about_flags.cc#newcode1341 ...
6 years, 7 months ago (2014-05-16 22:21:30 UTC) #3
Noam Samuel
https://codereview.chromium.org/292593002/diff/20001/components/cloud_devices/common/cloud_devices_switches.cc File components/cloud_devices/common/cloud_devices_switches.cc (right): https://codereview.chromium.org/292593002/diff/20001/components/cloud_devices/common/cloud_devices_switches.cc#newcode11 components/cloud_devices/common/cloud_devices_switches.cc:11: This is empty.
6 years, 7 months ago (2014-05-16 22:21:39 UTC) #4
Noam Samuel
lgtm https://codereview.chromium.org/292593002/diff/20001/components/cloud_devices/common/cloud_devices_switches.cc File components/cloud_devices/common/cloud_devices_switches.cc (right): https://codereview.chromium.org/292593002/diff/20001/components/cloud_devices/common/cloud_devices_switches.cc#newcode11 components/cloud_devices/common/cloud_devices_switches.cc:11: On 2014/05/16 22:21:39, Noam Samuel wrote: > This ...
6 years, 7 months ago (2014-05-16 22:22:15 UTC) #5
Noam Samuel
On 2014/05/16 22:22:15, Noam Samuel wrote: > lgtm > > https://codereview.chromium.org/292593002/diff/20001/components/cloud_devices/common/cloud_devices_switches.cc > File components/cloud_devices/common/cloud_devices_switches.cc (right): ...
6 years, 7 months ago (2014-05-16 22:22:56 UTC) #6
Vitaly Buka (NO REVIEWS)
On 2014/05/16 22:22:56, Noam Samuel wrote: > On 2014/05/16 22:22:15, Noam Samuel wrote: > > ...
6 years, 7 months ago (2014-05-16 22:24:01 UTC) #7
Noam Samuel
lgtm lgtm++
6 years, 7 months ago (2014-05-16 22:24:27 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-16 22:35:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/292593002/60001
6 years, 7 months ago (2014-05-16 23:33:58 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 06:32:08 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 07:23:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154775)
6 years, 7 months ago (2014-05-17 07:23:40 UTC) #13
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-17 16:58:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/292593002/60001
6 years, 7 months ago (2014-05-17 16:58:36 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 18:41:34 UTC) #16
Message was sent while issue was closed. 
Change committed as 271255

Powered by Google App Engine
This is Rietveld 408576698