Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: src/inspector/v8-debugger.h

Issue 2925903002: [inspector] Make breakpoints active state per-agent (Closed)
Patch Set: fixed wrong behavior Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/inspector/v8-debugger.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INSPECTOR_V8DEBUGGER_H_ 5 #ifndef V8_INSPECTOR_V8DEBUGGER_H_
6 #define V8_INSPECTOR_V8DEBUGGER_H_ 6 #define V8_INSPECTOR_V8DEBUGGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 26 matching lines...) Expand all
37 public: 37 public:
38 V8Debugger(v8::Isolate*, V8InspectorImpl*); 38 V8Debugger(v8::Isolate*, V8InspectorImpl*);
39 ~V8Debugger(); 39 ~V8Debugger();
40 40
41 bool enabled() const; 41 bool enabled() const;
42 v8::Isolate* isolate() const { return m_isolate; } 42 v8::Isolate* isolate() const { return m_isolate; }
43 43
44 String16 setBreakpoint(const ScriptBreakpoint&, int* actualLineNumber, 44 String16 setBreakpoint(const ScriptBreakpoint&, int* actualLineNumber,
45 int* actualColumnNumber); 45 int* actualColumnNumber);
46 void removeBreakpoint(const String16& breakpointId); 46 void removeBreakpoint(const String16& breakpointId);
47 void setBreakpointsActivated(bool); 47 void setBreakpointsActive(bool);
48 bool breakpointsActivated() const { return m_breakpointsActivated; }
49 48
50 v8::debug::ExceptionBreakState getPauseOnExceptionsState(); 49 v8::debug::ExceptionBreakState getPauseOnExceptionsState();
51 void setPauseOnExceptionsState(v8::debug::ExceptionBreakState); 50 void setPauseOnExceptionsState(v8::debug::ExceptionBreakState);
52 bool canBreakProgram(); 51 bool canBreakProgram();
53 void breakProgram(int targetContextGroupId); 52 void breakProgram(int targetContextGroupId);
54 void continueProgram(int targetContextGroupId); 53 void continueProgram(int targetContextGroupId);
55 void breakProgramOnAssert(int targetContextGroupId); 54 void breakProgramOnAssert(int targetContextGroupId);
56 55
57 void setPauseOnNextStatement(bool, int targetContextGroupId); 56 void setPauseOnNextStatement(bool, int targetContextGroupId);
58 void stepIntoStatement(int targetContextGroupId); 57 void stepIntoStatement(int targetContextGroupId);
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 v8::Local<v8::Value> promise, bool is_uncaught) override; 175 v8::Local<v8::Value> promise, bool is_uncaught) override;
177 bool IsFunctionBlackboxed(v8::Local<v8::debug::Script> script, 176 bool IsFunctionBlackboxed(v8::Local<v8::debug::Script> script,
178 const v8::debug::Location& start, 177 const v8::debug::Location& start,
179 const v8::debug::Location& end) override; 178 const v8::debug::Location& end) override;
180 179
181 int currentContextGroupId(); 180 int currentContextGroupId();
182 181
183 v8::Isolate* m_isolate; 182 v8::Isolate* m_isolate;
184 V8InspectorImpl* m_inspector; 183 V8InspectorImpl* m_inspector;
185 int m_enableCount; 184 int m_enableCount;
186 bool m_breakpointsActivated; 185 int m_breakpointsActiveCount = 0;
187 v8::Global<v8::Object> m_debuggerScript; 186 v8::Global<v8::Object> m_debuggerScript;
188 v8::Global<v8::Context> m_debuggerContext; 187 v8::Global<v8::Context> m_debuggerContext;
189 v8::Local<v8::Object> m_executionState; 188 v8::Local<v8::Object> m_executionState;
190 v8::Local<v8::Context> m_pausedContext; 189 v8::Local<v8::Context> m_pausedContext;
191 int m_ignoreScriptParsedEventsCounter; 190 int m_ignoreScriptParsedEventsCounter;
192 bool m_scheduledOOMBreak = false; 191 bool m_scheduledOOMBreak = false;
193 bool m_scheduledAssertBreak = false; 192 bool m_scheduledAssertBreak = false;
194 int m_targetContextGroupId = 0; 193 int m_targetContextGroupId = 0;
195 int m_pausedContextGroupId = 0; 194 int m_pausedContextGroupId = 0;
196 String16 m_continueToLocationBreakpointId; 195 String16 m_continueToLocationBreakpointId;
(...skipping 30 matching lines...) Expand all
227 v8::debug::ExceptionBreakState m_pauseOnExceptionsState; 226 v8::debug::ExceptionBreakState m_pauseOnExceptionsState;
228 227
229 WasmTranslation m_wasmTranslation; 228 WasmTranslation m_wasmTranslation;
230 229
231 DISALLOW_COPY_AND_ASSIGN(V8Debugger); 230 DISALLOW_COPY_AND_ASSIGN(V8Debugger);
232 }; 231 };
233 232
234 } // namespace v8_inspector 233 } // namespace v8_inspector
235 234
236 #endif // V8_INSPECTOR_V8DEBUGGER_H_ 235 #endif // V8_INSPECTOR_V8DEBUGGER_H_
OLDNEW
« no previous file with comments | « no previous file | src/inspector/v8-debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698