Remove unused code in DesktopScreenPositionClient

ui/views/widget/desktop_aura/desktop_screen_position_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_screen_position_client.h"
 
 #include "ui/aura/window_tree_host.h"
 #include "ui/gfx/display.h"
 #include "ui/gfx/point_conversions.h"
 #include "ui/gfx/screen.h"
-#include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 
 namespace views {
 
 namespace {
 
 gfx::Point GetOrigin(const aura::Window* root_window) {
   gfx::Point origin_in_pixels =
       root_window->GetHost()->GetBounds().origin();
   aura::Window* window = const_cast<aura::Window*>(root_window);
   float scale = gfx::Screen::GetScreenFor(window)->
@@ skipping 60 matching lines @@
 
     gfx::Point origin = bounds.origin();
     aura::Window::ConvertPointToTarget(window->parent(), root, &origin);
 
     gfx::Point host_origin = GetOrigin(root);
     origin.Offset(-host_origin.x(), -host_origin.y());
     window->SetBounds(gfx::Rect(origin, bounds.size()));
     return;
   }
 
-  internal::NativeWidgetPrivate* desktop_native_widget =
-      DesktopNativeWidgetAura::ForWindow(root);
-  if (desktop_native_widget &&

[sadrul, 2014/05/20 17:39:17]

Is this because DesktopNativeWidgetAura::ForWindow always returns NULL here? Can
you explain why?

[pkotwicz, 2014/05/20 19:11:13]

views::Widget::is_top_level() returns true if
    !params.child &&
    params.type != InitParams::TYPE_CONTROL &&
    params.type != InitParams::TYPE_TOOLTIP;

Thus, PositionWindowInScreenCoordinates() returns false if
    params.child || params.type == InitParams::TYPE_CONTROL
There should not be any DesktopNativeWidgetAuras in the cases that
PositionWindowInScreenCoordinates() returns false

[sadrul, 2014/05/20 20:03:10]

OK. Let's add DCHECK() for this, so we know to fix this if we start creating
DNWA for these cases.

[pkotwicz, 2014/05/20 21:27:25]

There is no point in a DCHECK. One could argue that when
PositionWindowInScreenCoordinates() returns true we should also call
root->GetHost()->SetBounds().

As the code stands right now (with or without this CL), one should not call
aura::Window::SetBoundsInScreen() on an aura::Window which has an associated
DNWA.

[sadrul, 2014/05/21 19:00:06]

Right. Do we have code to check that that call is not mistakenly being called?

-      desktop_native_widget->GetNativeView() == window) {
-    // |window| is the content_window.
-    // Setting bounds of root resizes |window|.
-    root->GetHost()->SetBounds(bounds);
-  } else {
-    window->SetBounds(bounds);
-  }
+  window->SetBounds(bounds);
 }
 
 }  // namespace views