Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 292583002: Move FakeAttachmentStore from IO thread to FILE thread. (Closed)

Created:
6 years, 7 months ago by maniscalco
Modified:
6 years, 7 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Move FakeAttachmentStore from IO thread to FILE thread. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271821

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Use FILE thread, not IO, for AttachmentStore. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
maniscalco
Pavel, would you please review this change? This should have been on the FILE thread ...
6 years, 7 months ago (2014-05-20 18:40:46 UTC) #1
pavely
lgtm
6 years, 7 months ago (2014-05-20 18:43:29 UTC) #2
maniscalco
The CQ bit was checked by maniscalco@chromium.org
6 years, 7 months ago (2014-05-20 19:59:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/292583002/40001
6 years, 7 months ago (2014-05-20 20:00:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 21:38:45 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 02:28:09 UTC) #6
Message was sent while issue was closed.
Change committed as 271821

Powered by Google App Engine
This is Rietveld 408576698