Permission prompts shouldn't cause browser to be focused

chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
index c9c7d11393499c30d1318aaa7a26d0aacd5b4265..e54c454eff384a70d150f002ff2cacf1d8e64ba1 100644
--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
@@ -13,6 +13,7 @@
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
+#include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/layout_constants.h"
 #include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
@@ -277,7 +278,13 @@ void PermissionPromptImpl::Show() {
   bubble_delegate_->set_anchor_view_insets(gfx::Insets(
       GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0));
 
-  views::BubbleDialogDelegateView::CreateBubble(bubble_delegate_)->Show();
+  views::Widget* widget =
+      views::BubbleDialogDelegateView::CreateBubble(bubble_delegate_);
+  if (browser_ == BrowserList::GetInstance()->GetLastActive()) {

[raymes, 2017/06/19 04:43:00]

nit: no {} needed

[tapted, 2017/06/20 11:11:32]

This should have a comment - it's pretty subtle why it's being done this way.
E.g.

// If a browser window (or popup) other than the bubble parent has focus, don't
take focus.

also is the choice of BrowserList intentional, rather than just using
browser_->window()->IsActive()? Using BrowserList means that windows from other
apps, or Packaged App windows, won't cause taking focus to be suppressed.

[Timothy Loh, 2017/06/21 07:17:41]

I copied the BrowserList check from 
app_modal_dialog_helper.cc/javascript_dialog_tab_helper.cc, but it sounds like
just checking if it's active is better so I changed it.

+    widget->Show();
+  } else {
+    widget->ShowInactive();
+  }
   bubble_delegate_->SizeToContents();
 
   bubble_delegate_->UpdateAnchor(GetAnchorView(),