Report signling errors for register-support-host requests.

remoting/host/register_support_host_request_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/register_support_host_request.h"
 
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "base/observer_list.h"
-#include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringize_macros.h"
 #include "base/test/mock_callback.h"
+#include "base/test/scoped_mock_time_message_loop_task_runner.h"
 #include "remoting/base/constants.h"
 #include "remoting/base/rsa_key_pair.h"
 #include "remoting/base/test_rsa_key_pair.h"
 #include "remoting/host/host_details.h"
+#include "remoting/protocol/errors.h"
 #include "remoting/signaling/iq_sender.h"
 #include "remoting/signaling/mock_signal_strategy.h"
 #include "remoting/signaling/signaling_address.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/libjingle_xmpp/xmllite/xmlelement.h"
 #include "third_party/libjingle_xmpp/xmpp/constants.h"
 
 using buzz::QName;
 using buzz::XmlElement;
@@ skipping 39 matching lines @@
         .WillRepeatedly(RemoveListener(&signal_strategy_listeners_));
   }
 
   base::MessageLoop message_loop_;
   MockSignalStrategy signal_strategy_;
   base::ObserverList<SignalStrategy::Listener, true> signal_strategy_listeners_;
   scoped_refptr<RsaKeyPair> key_pair_;
   base::MockCallback<RegisterSupportHostRequest::RegisterCallback> callback_;
 };
 
+TEST_F(RegisterSupportHostRequestTest, Timeout) {
+  std::unique_ptr<RegisterSupportHostRequest> request(
+      new RegisterSupportHostRequest(&signal_strategy_, key_pair_, kTestBotJid,
+                                     callback_.Get()));
+  EXPECT_CALL(signal_strategy_, GetNextId()).WillOnce(Return(kStanzaId));
+  EXPECT_CALL(signal_strategy_, SendStanzaPtr(NotNull()))
+      .WillOnce(Return(true));
+
+  request->OnSignalStrategyStateChange(SignalStrategy::CONNECTED);
+
+  // Generate response and verify that callback is called.
+  EXPECT_CALL(
+      callback_,
+      Run("", base::TimeDelta::FromSeconds(0),
+          protocol::ErrorCodeToString(protocol::ErrorCode::SIGNALING_TIMEOUT)));
+
+  mock_time_task_runner_->FastForwardBy(base::TimeDelta::FromSeconds(15));

[Sergey Ulanov, 2017/06/07 06:41:30]

Where is mock_time_task_runner_ defined?

[kelvinp, 2017/06/12 21:31:26]

Good catch. It is a bad merge =(

+}
+
 TEST_F(RegisterSupportHostRequestTest, Send) {
   // |iq_request| is freed by RegisterSupportHostRequest.
   int64_t start_time = static_cast<int64_t>(base::Time::Now().ToDoubleT());
 
   std::unique_ptr<RegisterSupportHostRequest> request(
       new RegisterSupportHostRequest(&signal_strategy_, key_pair_, kTestBotJid,
                                      callback_.Get()));
 
   XmlElement* sent_iq = nullptr;
   EXPECT_CALL(signal_strategy_, GetNextId())
       .WillOnce(Return(kStanzaId));
   EXPECT_CALL(signal_strategy_, SendStanzaPtr(NotNull()))
       .WillOnce(DoAll(SaveArg<0>(&sent_iq), Return(true)));
 
   request->OnSignalStrategyStateChange(SignalStrategy::CONNECTED);
-  base::RunLoop().RunUntilIdle();
+  mock_time_task_runner_->RunUntilIdle();
 
   // Verify format of the query.
   std::unique_ptr<XmlElement> stanza(sent_iq);
   ASSERT_TRUE(stanza != nullptr);
 
   EXPECT_EQ(stanza->Attr(buzz::QName(std::string(), "to")),
             std::string(kTestBotJid));
   EXPECT_EQ(stanza->Attr(buzz::QName(std::string(), "type")), "set");
 
   EXPECT_EQ(QName(kChromotingXmlNamespace, "register-support-host"),
@@ skipping 54 matching lines @@
   support_id_lifetime->AddText(kSupportIdLifetime);
   result->AddElement(support_id_lifetime);
 
   int consumed = 0;
   for (auto& listener : signal_strategy_listeners_) {
     if (listener.OnSignalStrategyIncomingStanza(response.get()))
       consumed++;
   }
   EXPECT_EQ(1, consumed);
 
-  base::RunLoop().RunUntilIdle();
+  mock_time_task_runner_->RunUntilIdle();
 }
 
 }  // namespace remoting