Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: components/translate/core/browser/BUILD.gn

Issue 2925733002: Move ranker_model_loader to a new component. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/BUILD.gn
diff --git a/components/translate/core/browser/BUILD.gn b/components/translate/core/browser/BUILD.gn
index f7ad715dc37ac52fb276e64f78bd83099ad58c7f..89c7645185ed22a7dda3832ab7bfd77d68a4696d 100644
--- a/components/translate/core/browser/BUILD.gn
+++ b/components/translate/core/browser/BUILD.gn
@@ -11,10 +11,6 @@ static_library("browser") {
"language_state.cc",
"language_state.h",
"page_translated_details.h",
- "ranker_model.cc",
- "ranker_model.h",
- "ranker_model_loader.cc",
- "ranker_model_loader.h",
"translate_accept_languages.cc",
"translate_accept_languages.h",
"translate_browser_metrics.cc",
@@ -60,9 +56,9 @@ static_library("browser") {
"//components/metrics/proto",
"//components/pref_registry",
"//components/prefs",
+ "//components/ranker",
"//components/resources:components_resources",
"//components/strings",
- "//components/translate/core/browser/proto",
"//components/translate/core/common",
"//components/ukm",
"//components/variations",
@@ -100,8 +96,6 @@ source_set("unit_tests") {
"mock_translate_driver.h",
"mock_translate_ranker.cc",
"mock_translate_ranker.h",
- "ranker_model_loader_unittest.cc",
- "ranker_model_unittest.cc",
"translate_browser_metrics_unittest.cc",
"translate_language_list_unittest.cc",
"translate_manager_unittest.cc",
@@ -118,8 +112,8 @@ source_set("unit_tests") {
"//components/pref_registry:pref_registry",
"//components/prefs",
"//components/prefs:test_support",
+ "//components/ranker",
"//components/sync_preferences:test_support",
- "//components/translate/core/browser/proto",
"//components/translate/core/common",
"//components/ukm",
"//components/ukm:test_support",

Powered by Google App Engine
This is Rietveld 408576698