chrome/browser/safe_browsing/threat_details_unittest.cc - Issue 2925693003: Making CSD ReportType enum consistent.

Unified Diff: chrome/browser/safe_browsing/threat_details_unittest.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)

Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc ('k') | chrome/browser/ssl/security_state_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/threat_details_unittest.cc

diff --git a/chrome/browser/safe_browsing/threat_details_unittest.cc b/chrome/browser/safe_browsing/threat_details_unittest.cc

index 2ed74e7f687c86d180fa1aaa623c9010c9da9ea9..1be5e57a61329f7b1ea72d3f37973ad86ebad817 100644

--- a/chrome/browser/safe_browsing/threat_details_unittest.cc

+++ b/chrome/browser/safe_browsing/threat_details_unittest.cc

@@ -1081,7 +1081,7 @@ TEST_F(ThreatDetailsTest, HTTPCache) {

->NavigateAndCommit(GURL(kLandingURL));

UnsafeResource resource;

- InitResource(&resource, SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL,

+ InitResource(&resource, SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING,

true /* is_subresource */, GURL(kThreatURL));

scoped_refptr<ThreatDetailsWrap> report =

@@ -1107,7 +1107,7 @@ TEST_F(ThreatDetailsTest, HTTPCache) {

actual.ParseFromString(serialized);

ClientSafeBrowsingReportRequest expected;

- expected.set_type(ClientSafeBrowsingReportRequest::CLIENT_SIDE_PHISHING_URL);

+ expected.set_type(ClientSafeBrowsingReportRequest::URL_CLIENT_SIDE_PHISHING);

expected.set_url(kThreatURL);

expected.set_page_url(kLandingURL);

expected.set_referrer_url("");

@@ -1164,7 +1164,7 @@ TEST_F(ThreatDetailsTest, HttpsResourceSanitization) {

->NavigateAndCommit(GURL(kLandingURL));

UnsafeResource resource;

- InitResource(&resource, SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL,

+ InitResource(&resource, SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING,

true /* is_subresource */, GURL(kThreatURLHttps));

scoped_refptr<ThreatDetailsWrap> report =

@@ -1190,7 +1190,7 @@ TEST_F(ThreatDetailsTest, HttpsResourceSanitization) {

actual.ParseFromString(serialized);

ClientSafeBrowsingReportRequest expected;

- expected.set_type(ClientSafeBrowsingReportRequest::CLIENT_SIDE_PHISHING_URL);

+ expected.set_type(ClientSafeBrowsingReportRequest::URL_CLIENT_SIDE_PHISHING);

expected.set_url(kThreatURLHttps);

expected.set_page_url(kLandingURL);

expected.set_referrer_url("");

@@ -1244,7 +1244,7 @@ TEST_F(ThreatDetailsTest, HTTPCacheNoEntries) {

->NavigateAndCommit(GURL(kLandingURL));

UnsafeResource resource;

- InitResource(&resource, SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL,

+ InitResource(&resource, SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE,

true /* is_subresource */, GURL(kThreatURL));

scoped_refptr<ThreatDetailsWrap> report =

@@ -1267,7 +1267,7 @@ TEST_F(ThreatDetailsTest, HTTPCacheNoEntries) {

actual.ParseFromString(serialized);

ClientSafeBrowsingReportRequest expected;

- expected.set_type(ClientSafeBrowsingReportRequest::CLIENT_SIDE_MALWARE_URL);

+ expected.set_type(ClientSafeBrowsingReportRequest::URL_CLIENT_SIDE_MALWARE);

expected.set_url(kThreatURL);

expected.set_page_url(kLandingURL);

expected.set_referrer_url("");