chrome/browser/safe_browsing/download_protection_service_unittest.cc - Issue 2925693003: Making CSD ReportType enum consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)

Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.cc ('k') | chrome/browser/safe_browsing/local_database_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

index e8d6a592bce135a9bc4ae9942de860e06deee307..eee257605c41975c25af6db9c2d0516c26379f21 100644

--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

@@ -233,7 +233,7 @@ ACTION_P(CheckDownloadUrlDone, threat_type) {

LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck* check =

new LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck(

arg0, std::vector<SBFullHash>(), arg1, BINURL,

- std::vector<SBThreatType>(1, SB_THREAT_TYPE_BINARY_MALWARE_URL));

+ std::vector<SBThreatType>(1, SB_THREAT_TYPE_URL_BINARY_MALWARE));

for (size_t i = 0; i < check->url_results.size(); ++i)

check->url_results[i] = threat_type;

BrowserThread::PostTask(

@@ -1797,7 +1797,7 @@ TEST_F(DownloadProtectionServiceTest, TestCheckDownloadUrl) {

{

EXPECT_CALL(*sb_service_->mock_database_manager(),

CheckDownloadUrl(ContainerEq(url_chain), NotNull()))

- .WillOnce(DoAll(CheckDownloadUrlDone(SB_THREAT_TYPE_BINARY_MALWARE_URL),

+ .WillOnce(DoAll(CheckDownloadUrlDone(SB_THREAT_TYPE_URL_BINARY_MALWARE),

Return(false)));

RunLoop run_loop;

download_service_->CheckDownloadUrl(