Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2925663006: WIP DO NOT MERGE: Cache current directory listing for local search.

Created:
3 years, 6 months ago by tetsui
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP DO NOT MERGE: Cache current directory listing for local search. Previously, current directory listing was not cached. Therefore, every time local search was performed, it re-fethed directory listing, which is very slow on MTP. It only caches right under the current directory, and local search is recursive. Therefore, some part of the search result is still not cached. TEST=manual BUG=716314 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -57 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 14 chunks +112 lines, -25 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 9 chunks +79 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (7 generated)
tetsui
Description was changed from ========== WIP DO NOT MERGE: Cache current directory listing for local ...
3 years, 6 months ago (2017-06-07 05:31:17 UTC) #1
tetsui
The CQ bit was checked by tetsui@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 05:31:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925663006/1
3 years, 6 months ago (2017-06-07 05:31:40 UTC) #3
tetsui
Description was changed from ========== WIP DO NOT MERGE: Cache current directory listing for local ...
3 years, 6 months ago (2017-06-07 05:33:04 UTC) #4
tetsui
Description was changed from ========== WIP DO NOT MERGE: Cache current directory listing for local ...
3 years, 6 months ago (2017-06-07 05:33:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-07 06:50:16 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 06:50:17 UTC) #7
Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698