Issue 2925573002: Fix the test for ClassHierarchy.getDispatchTarget().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2925573002: Fix the test for ClassHierarchy.getDispatchTarget(). (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
ahe, Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix the test for ClassHierarchy.getDispatchTarget(). The blame was placed incorrectly - it was a bug in the test itself. We need both empty FunctionBody and isAbstract flag for Procedure. R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/71b1905265da535bbe4dc31a59bc7c96b532f0ce

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -38 lines)			Patch
	M	pkg/kernel/test/class_hierarchy_test.dart	View		6 chunks	+36 lines, -38 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 6 months ago (2017-06-05 17:42:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
71b1905265da535bbe4dc31a59bc7c96b532f0ce (presubmit successful).