Issue 2925463002: Add clientID and clientVersion to the diagnostics page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2925463002: Add clientID and clientVersion to the diagnostics page. (Closed)

Created:
3 years, 6 months ago by devoncarew

Modified:
3 years, 6 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -9 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/domain_completion.dart	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/server/driver.dart	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/status/diagnostics.dart	View	2 chunks	+13 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

devoncarew

- remember the clientID and clientVersion that's passed in on the cli - display this ...

3 years, 6 months ago (2017-06-03 18:42:17 UTC) #1

devoncarew

3 years, 6 months ago (2017-06-04 00:53:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4f2867d86c40d94b2af2a019e435674c139e55d6 (presubmit successful).