Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2925443002: Use failedAt in more places (ssa) (Closed)

Created:
3 years, 6 months ago by sra1
Modified:
3 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -90 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 27 chunks +67 lines, -55 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 7 chunks +21 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 3 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 1 chunk +9 lines, -8 lines 1 comment Download

Messages

Total messages: 5 (3 generated)
sra1
Committed patchset #1 (id:40001) manually as 7c4e5d53e74cc6ee57bd15e45dcab2ee57b21320 (presubmit successful).
3 years, 6 months ago (2017-06-03 12:11:12 UTC) #4
Johnni Winther
3 years, 6 months ago (2017-06-06 07:41:18 UTC) #5
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/2925443002/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/type_builder.dart (right):

https://codereview.chromium.org/2925443002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/type_builder.dart:171: contextClass == null ||
Assert can take a ()->bool as the first argument. If we rewrite, we avoid
eagerly computing contextClass.

Powered by Google App Engine
This is Rietveld 408576698