Issue 2925303002: [hot reload] Ensure old class table is also freed on success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2925303002: [hot reload] Ensure old class table is also freed on success. (Closed)

Created:
3 years, 6 months ago by rmacnak

Modified:
3 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[hot reload] Ensure we free the old class table even when there are no shape changes. Issue #28349 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/3b7b05eaa90e535dd042dbfeca149f96f6bed14c

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -40 lines)			Patch
	M	runtime/tests/vm/vm.status	View		1 chunk	+0 lines, -39 lines	0 comments	Download
	M	runtime/vm/isolate_reload.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

rmacnak

3 years, 6 months ago (2017-06-08 21:13:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3b7b05eaa90e535dd042dbfeca149f96f6bed14c (presubmit successful).