Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2925273003: Make common tests consistent (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -99 lines) Patch
M pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart View 19 chunks +20 lines, -20 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/type_member_contributor_test.dart View 58 chunks +78 lines, -78 lines 0 comments Download
M pkg/analyzer_plugin/test/utilities/completion/type_member_contributor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
After all the CL's yesterday I decided to make sure I hadn't missed something. This ...
3 years, 6 months ago (2017-06-08 14:55:41 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-08 16:43:10 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-09 15:40:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e6586492d3cd5d24400a9dedda3304bea391736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698