A step towards handling `new Object()` in compile_from_dill_test

pkg/compiler/lib/src/elements/common.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Mixins that implement convenience methods on [Element] subclasses.
 
 library elements.common;
 
 import '../common/names.dart' show Identifiers, Names, Uris;
 import '../common_elements.dart' show CommonElements;
@@ skipping 455 matching lines @@
     return member != null && member.isMethod ? member.type : null;
   }
 
   @override
   bool get isNamedMixinApplication {
     return isMixinApplication && !isUnnamedMixinApplication;
   }
 
   // backendMembers are members that have been added by the backend to simplify
   // compilation. They don't have any user-side counter-part.
-  Link<Element> backendMembers = const Link<Element>();
+  Link<ConstructorBodyElement> backendMembers =

[Siggi Cherem (dart-lang), 2017/06/08 18:01:46]

TODO: rename?

[Johnni Winther, 2017/06/09 09:28:49]

Renamed all methods - and removed the reverseBackendMembers by using a List
instead of a Link.

+      const Link<ConstructorBodyElement>();
 
   bool get hasBackendMembers => !backendMembers.isEmpty;
 
-  void addBackendMember(Element member) {
+  void addBackendMember(ConstructorBodyElement member) {
     // TODO(ngeoffray): Deprecate this method.
     assert(member.isGenerativeConstructorBody);
     backendMembers = backendMembers.prepend(member);
   }
 
   void reverseBackendMembers() {
     backendMembers = backendMembers.reverse();
   }
 
   /// Lookup a synthetic element created by the backend.
-  Element lookupBackendMember(String memberName) {
-    for (Element element in backendMembers) {
+  ConstructorBodyElement lookupBackendMember(String memberName) {
+    for (ConstructorBodyElement element in backendMembers) {
       if (element.name == memberName) {
         return element;
       }
     }
     return null;
   }
 
-  void forEachBackendMember(void f(Element member)) {
+  void forEachBackendMember(void f(ConstructorBodyElement member)) {
     backendMembers.forEach(f);
   }
 }
 
 abstract class FunctionSignatureCommon implements FunctionSignature {
   ParameterStructure _parameterStructure;
 
   ResolutionDartType get returnType => type.returnType;
 
   void forEachRequiredParameter(void function(Element parameter)) {
@@ skipping 162 matching lines @@
   @override
   bool get isBoolFromEnvironmentConstructor {
     return fromEnvironmentState == _FromEnvironmentState.BOOL;
   }
 
   @override
   bool get isStringFromEnvironmentConstructor {
     return fromEnvironmentState == _FromEnvironmentState.STRING;
   }
 }