Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 292523004: app_list: DriveAppConverter to install local URL app from DriveAppInfo. (Closed)

Created:
6 years, 7 months ago by xiyuan
Modified:
6 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

app_list: DriveAppConverter to install local URL app from DriveAppInfo. BUG=358808 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271355

Patch Set 1 #

Total comments: 12

Patch Set 2 : for comments in #1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -0 lines) Patch
A chrome/browser/ui/app_list/drive/drive_app_converter.h View 1 1 chunk +69 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/drive/drive_app_converter.cc View 1 1 chunk +193 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/drive/drive_app_converter_browsertest.cc View 1 1 chunk +151 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xiyuan
6 years, 7 months ago (2014-05-16 17:54:26 UTC) #1
calamity
Mostly lg. Just a couple of nits and questions. https://codereview.chromium.org/292523004/diff/1/chrome/browser/ui/app_list/drive/drive_app_converter.cc File chrome/browser/ui/app_list/drive/drive_app_converter.cc (right): https://codereview.chromium.org/292523004/diff/1/chrome/browser/ui/app_list/drive/drive_app_converter.cc#newcode28 chrome/browser/ui/app_list/drive/drive_app_converter.cc:28: ...
6 years, 7 months ago (2014-05-19 04:01:07 UTC) #2
xiyuan
https://codereview.chromium.org/292523004/diff/1/chrome/browser/ui/app_list/drive/drive_app_converter.cc File chrome/browser/ui/app_list/drive/drive_app_converter.cc (right): https://codereview.chromium.org/292523004/diff/1/chrome/browser/ui/app_list/drive/drive_app_converter.cc#newcode28 chrome/browser/ui/app_list/drive/drive_app_converter.cc:28: class DriveAppConverter::IconFetcher : public net::URLFetcherDelegate, On 2014/05/19 04:01:08, calamity ...
6 years, 7 months ago (2014-05-19 06:08:14 UTC) #3
calamity
lgtm
6 years, 7 months ago (2014-05-19 06:13:27 UTC) #4
xiyuan
The CQ bit was checked by xiyuan@chromium.org
6 years, 7 months ago (2014-05-19 06:25:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/292523004/20001
6 years, 7 months ago (2014-05-19 06:25:56 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 09:25:15 UTC) #7
Message was sent while issue was closed.
Change committed as 271355

Powered by Google App Engine
This is Rietveld 408576698