Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 292523002: Do not call into blink before initialization (Closed)

Created:
6 years, 7 months ago by boliu
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Do not call into blink before initialization OnMemoryPressure can be called before blink is initialized, which can cause a crash. See bug for details. BUG=374211 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271216

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/renderer/render_thread_impl.cc View 1 chunk +6 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
boliu
PTAL, thanks! https://codereview.chromium.org/292523002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/292523002/diff/1/content/renderer/render_thread_impl.cc#newcode1421 content/renderer/render_thread_impl.cc:1421: v8::V8::LowMemoryNotification(); Could skip v8 and skia as ...
6 years, 7 months ago (2014-05-16 16:31:15 UTC) #1
piman
lgtm
6 years, 7 months ago (2014-05-16 19:31:42 UTC) #2
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 7 months ago (2014-05-16 19:32:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/292523002/1
6 years, 7 months ago (2014-05-16 19:33:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 07:46:00 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 16:00:49 UTC) #6
Message was sent while issue was closed.
Change committed as 271216

Powered by Google App Engine
This is Rietveld 408576698