Load service isolate from the kernel binary.

runtime/bin/dfe.cc

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dfe.h"
 #include "bin/dartutils.h"
 #include "bin/error_exit.h"
 
 #include "vm/kernel.h"
 
@@ skipping 75 matching lines @@
 
 void* DFE::ReadPlatform() {
   const uint8_t* buffer = NULL;
   intptr_t buffer_length = -1;
   bool result =
       TryReadKernelFile(platform_binary_filename_, &buffer, &buffer_length);
   if (result) {
     kernel_platform_ = Dart_ReadKernelBinary(buffer, buffer_length);
     return kernel_platform_;
   }
   return NULL;

[siva, 2017/06/13 02:12:02]

I think this can also be changed to
{
  kernel_platform_ = ReadScript(platform_binary_filename_);
  return kernel_platform_;
}

[sivachandra, 2017/06/14 19:25:57]

Doing this in https://codereview.chromium.org/2933203004/.

 }
 
 
+void* DFE::ReadVMServiceIO() {
+  const uint8_t* buffer = NULL;
+  intptr_t buffer_length = -1;
+  bool result =
+      TryReadKernelFile(vmservice_io_binary_filename_, &buffer, &buffer_length);
+  if (result) {
+    kernel_vmservice_io_ = Dart_ReadKernelBinary(buffer, buffer_length);
+    return kernel_vmservice_io_;
+  }
+  return NULL;

[siva, 2017/06/13 02:12:02]

Can this be:

{
  kernel_vmservice_io_ = ReadScript(vmservice_io_binary_filename_);
  return kernel_vmservice_io_;
}

[sivachandra, 2017/06/14 19:25:57]

Will update this after https://codereview.chromium.org/2933203004/ lands.

+}
+
+
 void* DFE::ReadScript(const char* script_uri) {
   const uint8_t* buffer = NULL;
   intptr_t buffer_length = -1;
   bool result = TryReadKernelFile(script_uri, &buffer, &buffer_length);
   if (result) {
     return Dart_ReadKernelBinary(buffer, buffer_length);
   }
   return NULL;
 }
 
@@ skipping 27 matching lines @@
         return true;
       }
     }
   }
   return false;
 }
 
 
 }  // namespace bin
 }  // namespace dart