chrome/common/extensions/sync_helper.cc - Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/sync_helper.cc

Issue 2925193002: NOT YET READY: UMA recording the kind of target frame when extensions pierce browsing instance.

Patch Set: Rebasing... Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/sync_helper.cc

diff --git a/chrome/common/extensions/sync_helper.cc b/chrome/common/extensions/sync_helper.cc

index 9152450ffebaae4951f5c30f4743452a9adbace1..7b594fd23f25f9034751c021b38c5cf090b142aa 100644

--- a/chrome/common/extensions/sync_helper.cc

+++ b/chrome/common/extensions/sync_helper.cc

@@ -71,9 +71,6 @@ bool IsSyncable(const Extension* extension) {

case Manifest::TYPE_UNKNOWN:

case Manifest::TYPE_SHARED_MODULE:

return false;

- case Manifest::NUM_LOAD_TYPES:

- NOTREACHED();

}

NOTREACHED();

return false;