Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc

Issue 2925123002: NOCOMMIT PROTOTYPE [GRC] Tab CPU Usage Observer (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc
diff --git a/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc b/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc
index 0bc6d1ab9088b4ddbb7e79e2aae23d4fe3991750..5dc448887369521f2a946fad0c53b78451bdfb06 100644
--- a/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc
+++ b/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc
@@ -37,7 +37,7 @@ const int kCPUProfilingIntervalInSeconds = 5;
ProcessCoordinationUnitImpl::ProcessCoordinationUnitImpl(
const CoordinationUnitID& id,
std::unique_ptr<service_manager::ServiceContextRef> service_ref)
- : CoordinationUnitImpl(id, std::move(service_ref)), cpu_usage_(-1.0) {
+ : CoordinationUnitImpl(id, std::move(service_ref)) {
// ProcessCoordinationUnit ids should correspond to its pid
base::ProcessId pid = id.id;
#if defined(OS_WIN)
@@ -63,15 +63,12 @@ ProcessCoordinationUnitImpl::ProcessCoordinationUnitImpl(
ProcessCoordinationUnitImpl::~ProcessCoordinationUnitImpl() = default;
void ProcessCoordinationUnitImpl::MeasureProcessCPUUsage() {
- cpu_usage_ = process_metrics_->GetPlatformIndependentCPUUsage();
+ double cpu_usage = process_metrics_->GetPlatformIndependentCPUUsage();
+ SetProperty(mojom::PropertyType::kProcessCPUUsage, base::Value(cpu_usage));
repeating_timer_.Start(
FROM_HERE, base::TimeDelta::FromSeconds(kCPUProfilingIntervalInSeconds),
this, &ProcessCoordinationUnitImpl::MeasureProcessCPUUsage);
}
-double ProcessCoordinationUnitImpl::GetCPUUsageForTesting() {
- return cpu_usage_;
-}
-
} // namespace resource_coordinator

Powered by Google App Engine
This is Rietveld 408576698