[Payments] Implement payment instrument icons

components/payments/mojom/payment_app.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module payments.mojom;
 
 import "components/payments/mojom/payment_request.mojom";
 import "mojo/common/time.mojom";
 import "url/mojo/url.mojom";
 
 enum PaymentHandlerStatus {
   SUCCESS,
   NOT_IMPLEMENTED,
   NOT_FOUND,
   NO_ACTIVE_WORKER,
   STORAGE_OPERATION_FAILED,
+  FETCH_INSTRUMENT_ICON_FAILED,
+};
+
+struct ImageObject {
+  string src;

[please use gerrit instead, 2017/06/08 21:34:10]

use mojom.url.GURL instead.

[gogerald1, 2017/06/09 14:23:24]

Why using mojom.url.GURL? PaymentInstruments has get method in the spec which
should return exact content used in set method.
https://w3c.github.io/payment-handler/#paymentinstruments-interface

So it looks better to store original representation of them directly, instead
convert them back and forth. 

[please use gerrit instead, 2017/06/09 14:52:53]

A strict IPC interface is better for security. (This data will always be a URL.)
In fact, using the GURL object up-and-down the full stack that passes around
this variable is preferable.

See "url.mojom.Url top_level_origin" below for example.

[gogerald1, 2017/06/09 18:50:55]

as talked offline

+  string sizes;

[please use gerrit instead, 2017/06/08 21:34:10]

This is never used. Discard, please. If you need it, then use an array of
integer pairs.

struct ImageSize {
  int32_t height;
  int32_t width;
}

array<ImageSize> sizes;

[gogerald1, 2017/06/09 14:23:24]

This is used by get interface. We could decode it when using it later. And the
usage is expected one time usage when fetching and decoding the instrument icon.

[please use gerrit instead, 2017/06/09 14:52:53]

All additional parameters increase the attack surface for IPC messages. Adding a
parameter that's not used increases the attack surface without any benefits.
Therefore, parameters should be added at the time when they are being used. 

[gogerald1, 2017/06/09 18:50:56]

Done.

+  string type;

[please use gerrit instead, 2017/06/08 21:34:10]

This is never used. Discard, please. If you need it, use an enum instead.

[gogerald1, 2017/06/09 14:23:23]

ditto

[gogerald1, 2017/06/09 18:50:55]

Done.

 };
 
 struct PaymentInstrument {
   string name;
+  array<ImageObject> icons;
   array<string> enabled_methods;
   string stringified_capabilities;
 };
 
 interface PaymentManager {
   Init(string service_worker_scope);
   DeletePaymentInstrument(string instrument_key)
       => (PaymentHandlerStatus status);
   GetPaymentInstrument(string instrument_key)
       => (PaymentInstrument instrument, PaymentHandlerStatus status);
@@ skipping 21 matching lines @@
   string method_name;
   string stringified_details;
 };
 
 // This interface is provided to pass a payment app response from payment
 // request event in renderer side to browser side by calling respondWith().
 interface PaymentAppResponseCallback {
   OnPaymentAppResponse(PaymentAppResponse response,
                        mojo.common.mojom.Time dispatch_event_time);
 };