[Payments] Implement payment instrument icons

components/payments/mojom/payment_app.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module payments.mojom;
 
 import "components/payments/mojom/payment_request.mojom";
 import "mojo/common/time.mojom";
 import "url/mojo/url.mojom";
 
 enum PaymentHandlerStatus {
   SUCCESS,
   NOT_IMPLEMENTED,
   NOT_FOUND,
   NO_ACTIVE_WORKER,
   STORAGE_OPERATION_FAILED,
+  FETCH_INSTRUMENT_ICON_FAILED,
+};
+
+struct ImageObject {
+  url.mojom.Url src;
 };
 
 struct PaymentInstrument {

[dcheng, 2017/06/10 00:37:10]

In general, this mojom file needs more comments. It's not clear what interfaces
live in the browser vs the renderer or some other process, nor what the
different structs mean / what they correspond to.

[gogerald1, 2017/06/12 16:19:43]

Done. Add few simple comments.

   string name;
+  array<ImageObject> icons;
   array<string> enabled_methods;
   string stringified_capabilities;
 };
 
 interface PaymentManager {
   Init(string service_worker_scope);
   DeletePaymentInstrument(string instrument_key)
       => (PaymentHandlerStatus status);
   GetPaymentInstrument(string instrument_key)
       => (PaymentInstrument instrument, PaymentHandlerStatus status);
@@ skipping 21 matching lines @@
   string method_name;
   string stringified_details;
 };
 
 // This interface is provided to pass a payment app response from payment
 // request event in renderer side to browser side by calling respondWith().
 interface PaymentAppResponseCallback {
   OnPaymentAppResponse(PaymentAppResponse response,
                        mojo.common.mojom.Time dispatch_event_time);
 };