[Payments] Implement payment instrument icons

chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments;
 
 import android.support.test.filters.MediumTest;
 
 import org.junit.Rule;
 import org.junit.Test;
@@ skipping 47 matching lines @@
                 new PaymentAppFactory.PaymentAppFactoryAddition() {
                     @Override
                     public void create(WebContents webContents, Set<String> methodNames,
                             PaymentAppFactory.PaymentAppCreatedCallback callback) {
                         List<PaymentInstrument> instruments = new ArrayList<PaymentInstrument>();
 
                         if (instrumentPresence != NO_OPTIONS) {
                             instruments.add(new ServiceWorkerPaymentInstrument(webContents,
                                     0 /* swRegistrationId */, "new" /* instrumentId */,
                                     "Create BobPay account" /* label */,
-                                    new HashSet<String>(Arrays.asList("https://bobpay.com",
-                                            "basic-card")) /* methodNames */));
+                                    new HashSet<String>(Arrays.asList(
+                                            "https://bobpay.com", "basic-card")) /* methodNames */,

[dcheng, 2017/06/10 00:37:10]

Nit: this should probably using something like example.com. Using random domains
is a bit dangerous.

[gogerald1, 2017/06/12 16:19:43]

This is not a complete random domain, it is a fake payment method used
everywhere to explain and test payment request (even in spec).
https://cs.chromium.org/search/?q=bobpay&sq=package:chromium&type=cs

We've created a public test website for it as well, https://bobpay.xyz/

So I would like not change it at least in this CL

[dcheng, 2017/06/13 09:02:55]

Can we change it to point to the test domain we control rather than a random
third party domain?

[gogerald1, 2017/06/13 15:37:19]

Not completely understand what's the difference of using "https://bobpay.com"
and "https://example.com". They are used as method names instead of domains
here. Both of them are fake names. But "https://bobpay.com" is the name we used
everywhere in our code and document as example.

Anyway, this is not directly related to this CL and we already used it
everywhere, so I would like to not change it at least in this CL if you don't
mind.

[dcheng, 2017/06/13 17:33:15]

bobpay.com => points to a parked domain
bobpay.xyz => points to demo app

seems like we should point it to the demo app at least? We can certainly fix the
others in a followup, but fixing the ones we're changing anyway seems
reasonable.

[gogerald1, 2017/06/14 01:28:16]

Acknowledged. will bring it up in our team to discuss whether we want to make
these changes,

+                                    null /* icon*/));
                         }
 
                         if (instrumentPresence == TWO_OPTIONS) {
                             instruments.add(new ServiceWorkerPaymentInstrument(webContents,
                                     0 /* swRegistrationId */, "existing" /* instrumentId */,
                                     "Existing BobPay account" /* label */,
-                                    new HashSet<String>(Arrays.asList("https://bobpay.com",
-                                            "basic-card")) /* methodNames */));
+                                    new HashSet<String>(Arrays.asList(
+                                            "https://bobpay.com", "basic-card")) /* methodNames */,
+                                    null /* icon */));
                         }
 
                         callback.onPaymentAppCreated(
                                 new ServiceWorkerPaymentApp(webContents, instruments));
                         callback.onAllPaymentAppsCreated();
                     }
                 });
     }
 
     @Test
@@ skipping 19 matching lines @@
     @Test
     @MediumTest
     @Feature({"Payments"})
     public void testTwoOptions() throws InterruptedException, ExecutionException, TimeoutException {
         installMockServiceWorkerPaymentApp(TWO_OPTIONS);
         mPaymentRequestTestRule.triggerUIAndWait(mPaymentRequestTestRule.getReadyForInput());
         // TODO(tommyt): crbug.com/669876. Expand this test as we implement more
         // service worker based payment app functionality.
     }
 }