ALL-IN-ONE: Refactor ComputeInlineBoxPosition()

third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

Index: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
index 8795eb6b3f8b2a76961c3df53c7a35e9cb522301..1c85cc2f47e1fa9ecbaba813e0bb9e07d2920b28 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
@@ -303,9 +303,7 @@ TEST_F(VisibleUnitsTest, ComputeInlineBoxPositionMixedEditable) {
       Position::LastPositionInNode(sample), TextAffinity::kDownstream);
   // Should not be in infinite-loop
   EXPECT_EQ(nullptr, actual.inline_box);
-  // TODO(editing-dev): We should return 0 for |InlineBoxPosition| when
-  // |inline_box| is null.
-  EXPECT_EQ(2, actual.offset_in_box);

[Xiaocheng, 2017/06/08 21:34:12]

This is behavioral change.

[yosin_UTC9, 2017/06/09 01:55:55]

This comes from here:

ORIGINAL:
      inline_box = ToLayoutBox(layout_object)->InlineBoxWrapper();
      if (!inline_box || (caret_offset > inline_box->CaretMinOffset() &&
                          caret_offset < inline_box->CaretMaxOffset()))
        return InlineBoxPosition(inline_box, caret_offset);

     if (!inline_box)
        return InlineBoxPosition(inline_box, caret_offset);

Anyway, I'll move this change into another patch.

+  EXPECT_EQ(0, actual.offset_in_box);
 }
 
 TEST_F(VisibleUnitsTest, endOfDocument) {