[cast_channel] Implement CastSocketService::OpenSocket()

components/cast_channel/cast_socket_service_unittest.cc

Index: components/cast_channel/cast_socket_service_unittest.cc
diff --git a/components/cast_channel/cast_socket_service_unittest.cc b/components/cast_channel/cast_socket_service_unittest.cc
index 53141c73bf384a95b4668570b656c2c86add937c..ca4f9307326ce25c17585575556f47108c03305b 100644
--- a/components/cast_channel/cast_socket_service_unittest.cc
+++ b/components/cast_channel/cast_socket_service_unittest.cc
@@ -3,13 +3,20 @@
 // found in the LICENSE file.
 
 #include "components/cast_channel/cast_socket_service.h"
+#include "base/test/mock_callback.h"
 #include "components/cast_channel/cast_test_util.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 
+#include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::_;
+using testing::DoAll;
+using testing::Invoke;
+using testing::Return;
+using testing::ReturnRef;
 using testing::SaveArg;
+using testing::WithArgs;
 
 namespace cast_channel {
 
@@ -19,40 +26,35 @@ class CastSocketServiceTest : public testing::Test {
       : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
         cast_socket_service_(new CastSocketService()) {}
 
+  CastSocket* AddSocket(std::unique_ptr<CastSocket> socket) {
+    return cast_socket_service_->AddSocket(std::move(socket));
+  }
+
+  void TearDown() override { cast_socket_service_ = nullptr; }
+
  protected:
   content::TestBrowserThreadBundle thread_bundle_;
   scoped_refptr<CastSocketService> cast_socket_service_;
+  base::MockCallback<CastSocket::OnOpenCallback> mock_on_open_callback_;
+  MockCastSocketObserver mock_observer_;
 };
 
 TEST_F(CastSocketServiceTest, TestAddSocket) {
-  int channel_id_1 = 0;
   auto socket1 = base::MakeUnique<MockCastSocket>();
-  EXPECT_CALL(*socket1, set_id(_)).WillOnce(SaveArg<0>(&channel_id_1));
+  auto* socket_ptr1 = AddSocket(std::move(socket1));
+  EXPECT_NE(0, socket_ptr1->id());
 
-  int channel_id = cast_socket_service_->AddSocket(std::move(socket1));
-  EXPECT_EQ(channel_id_1, channel_id);
-  EXPECT_NE(0, channel_id_1);
-
-  int channel_id_2 = 0;
   auto socket2 = base::MakeUnique<MockCastSocket>();
-  EXPECT_CALL(*socket2, set_id(_)).WillOnce(SaveArg<0>(&channel_id_2));
-
-  auto* socket_ptr = socket2.get();
-  channel_id = cast_socket_service_->AddSocket(std::move(socket2));
-  EXPECT_EQ(channel_id_2, channel_id);
-  EXPECT_NE(channel_id_1, channel_id_2);
+  auto* socket_ptr2 = AddSocket(std::move(socket2));
+  EXPECT_NE(socket_ptr1->id(), socket_ptr2->id());
 
-  auto removed_socket = cast_socket_service_->RemoveSocket(channel_id);
-  EXPECT_EQ(socket_ptr, removed_socket.get());
+  auto removed_socket = cast_socket_service_->RemoveSocket(socket_ptr2->id());
+  EXPECT_EQ(socket_ptr2, removed_socket.get());
 
-  int channel_id_3 = 0;
   auto socket3 = base::MakeUnique<MockCastSocket>();
-  EXPECT_CALL(*socket3, set_id(_)).WillOnce(SaveArg<0>(&channel_id_3));
-
-  channel_id = cast_socket_service_->AddSocket(std::move(socket3));
-  EXPECT_EQ(channel_id_3, channel_id);
-  EXPECT_NE(channel_id_1, channel_id_3);
-  EXPECT_NE(channel_id_2, channel_id_3);
+  auto* socket_ptr3 = AddSocket(std::move(socket3));
+  EXPECT_NE(socket_ptr1->id(), socket_ptr3->id());
+  EXPECT_NE(socket_ptr2->id(), socket_ptr3->id());
 }
 
 TEST_F(CastSocketServiceTest, TestRemoveAndGetSocket) {
@@ -63,13 +65,32 @@ TEST_F(CastSocketServiceTest, TestRemoveAndGetSocket) {
   EXPECT_FALSE(socket);
 
   auto mock_socket = base::MakeUnique<MockCastSocket>();
-  EXPECT_CALL(*mock_socket, set_id(_));
 
-  auto* mock_socket_ptr = mock_socket.get();
-  channel_id = cast_socket_service_->AddSocket(std::move(mock_socket));
+  auto* mock_socket_ptr = AddSocket(std::move(mock_socket));
+  channel_id = mock_socket_ptr->id();
   EXPECT_EQ(mock_socket_ptr, cast_socket_service_->GetSocket(channel_id));
+
   socket = cast_socket_service_->RemoveSocket(channel_id);
   EXPECT_TRUE(socket);
 }
 
+TEST_F(CastSocketServiceTest, TestOpenChannel) {
+  auto* mock_socket = new MockCastSocket();
+  auto ip_endpoint = CreateIPEndPointForTest();
+  mock_socket->SetIPEndpoint(ip_endpoint);
+  cast_socket_service_->SetSocketForTest(base::WrapUnique(mock_socket));
+
+  EXPECT_CALL(*mock_socket, Connect(_))
+      .WillOnce(
+          WithArgs<0>(Invoke([&](const CastSocket::OnOpenCallback& callback) {
+            callback.Run(mock_socket->id(), ChannelError::NONE);
+          })));
+  EXPECT_CALL(mock_on_open_callback_, Run(_, ChannelError::NONE));
+  EXPECT_CALL(*mock_socket, AddObserver(_));
+
+  cast_socket_service_->OpenSocket(ip_endpoint, nullptr /* net_log */,
+                                   mock_on_open_callback_.Get(),
+                                   &mock_observer_);
+}
+
 }  // namespace cast_channel