[cast_channel] Implement CastSocketService::OpenSocket()

components/cast_channel/cast_socket.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CAST_CHANNEL_CAST_SOCKET_H_
 #define COMPONENTS_CAST_CHANNEL_CAST_SOCKET_H_
 
 #include <stdint.h>
 
 #include <queue>
@@ skipping 38 matching lines @@
   VIDEO_OUT = 1 << 0,
   VIDEO_IN = 1 << 1,
   AUDIO_OUT = 1 << 2,
   AUDIO_IN = 1 << 3,
   DEV_MODE = 1 << 4
 };
 
 // Public interface of the CastSocket class.
 class CastSocket {
  public:
-  using ChannelError = ::cast_channel::ChannelError;
-  using ChannelAuthType = ::cast_channel::ChannelAuthType;
-  using ReadyState = ::cast_channel::ReadyState;
-
   virtual ~CastSocket() {}
 
   // Used by BrowserContextKeyedAPIFactory.
   static const char* service_name() { return "CastSocketImplManager"; }
 
   // Connects the channel to the peer. If successful, the channel will be in
   // READY_STATE_OPEN.  DO NOT delete the CastSocket object in |callback|.
   // Instead use Close().
   // |callback| will be invoked with any ChannelError that occurred, or
   // CHANNEL_ERROR_NONE if successful.
@@ skipping 51 matching lines @@
 
 // This class implements a channel between Chrome and a Cast device using a TCP
 // socket with SSL.  The channel may authenticate that the receiver is a genuine
 // Cast device.  All CastSocketImpl objects must be used only on the IO thread.
 //
 // NOTE: Not called "CastChannel" to reduce confusion with the generated API
 // code.
 class CastSocketImpl : public CastSocket {
  public:
   // Creates a new CastSocket that connects to |ip_endpoint| with
-  // |channel_auth|. |owner_extension_id| is the id of the extension that opened
-  // the socket.  |channel_auth| must not be CHANNEL_AUTH_NONE.
+  // |channel_auth|. |channel_auth| must not be CHANNEL_AUTH_NONE.

[mark a. foltz, 2017/06/12 21:14:08]

CHANNEL_AUTH_NONE has been removed from the IDL, so this comment is out of date.
 It would also be good to remove the channel_auth parameter from these classes
but that might be simpler to do in a separate change.

[zhaobin, 2017/06/20 01:37:41]

Created crbug.com/732669

   // Parameters:
-  // |owner_extension_id|: ID of the extension calling the API.
   // |ip_endpoint|: IP address of the remote host.
   // |channel_auth|: Authentication method used for connecting to a Cast
   //                 receiver.
   // |net_log|: Log of socket events.
   // |connect_timeout|: Connection timeout interval.
   // |logger|: Log of cast channel events.
-  CastSocketImpl(const std::string& owner_extension_id,
-                 const net::IPEndPoint& ip_endpoint,
+  CastSocketImpl(const net::IPEndPoint& ip_endpoint,
                  ChannelAuthType channel_auth,
                  net::NetLog* net_log,
                  const base::TimeDelta& connect_timeout,
                  bool keep_alive,
                  const scoped_refptr<Logger>& logger,
                  uint64_t device_capabilities);
 
   // For test-only.
   // This constructor allows for setting a custom AuthContext.
-  CastSocketImpl(const std::string& owner_extension_id,
-                 const net::IPEndPoint& ip_endpoint,
+  CastSocketImpl(const net::IPEndPoint& ip_endpoint,
                  ChannelAuthType channel_auth,
                  net::NetLog* net_log,
                  const base::TimeDelta& connect_timeout,
                  bool keep_alive,
                  const scoped_refptr<Logger>& logger,
                  uint64_t device_capabilities,
                  const AuthContext& auth_context);
 
   // Ensures that the socket is closed.
   ~CastSocketImpl() override;
@@ skipping 218 matching lines @@
 
   // Raw pointer to the auth handshake delegate. Used to get detailed error
   // information.
   AuthTransportDelegate* auth_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(CastSocketImpl);
 };
 }  // namespace cast_channel
 
 #endif  // COMPONENTS_CAST_CHANNEL_CAST_SOCKET_H_