[NTP::Push] Adding BreakingNewsSuggestionsProvider

components/ntp_snippets/content_suggestions_metrics.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/content_suggestions_metrics.h"
 
 #include <cmath>
 #include <string>
 #include <type_traits>
 
@@ skipping 50 matching lines @@
 const char kHistogramCategoryDismissed[] =
     "NewTabPage.ContentSuggestions.CategoryDismissed";
 const char kHistogramTimeSinceSuggestionFetched[] =
     "NewTabPage.ContentSuggestions.TimeSinceSuggestionFetched";
 
 const char kPerCategoryHistogramFormat[] = "%s.%s";
 
 // This mostly corresponds to the KnownCategories enum, but it is contiguous
 // and contains exactly the values to be recorded in UMA. Don't remove or
 // reorder elements, only add new ones at the end (before COUNT), and keep in
 // sync with ContentSuggestionsCategory in histograms.xml.

[jkrcal, 2017/06/09 11:32:59]

Sync with ContentSuggestionsCategory in histograms.xml.

[mamir, 2017/06/09 14:41:01]

Done.

 enum HistogramCategories {
   EXPERIMENTAL,
   RECENT_TABS,
   DOWNLOADS,
   BOOKMARKS,
   PHYSICAL_WEB_PAGES,
   FOREIGN_TABS,
   ARTICLES,
   READING_LIST,
+  BREAKING_NEWS,
   // Insert new values here!
   COUNT
 };
 
 HistogramCategories GetHistogramCategory(Category category) {
   static_assert(
       std::is_same<decltype(category.id()),
                    typename std::underlying_type<KnownCategories>::type>::value,
       "KnownCategories must have the same underlying type as category.id()");
   // Note: Since the underlying type of KnownCategories is int, it's legal to
   // cast from int to KnownCategories, even if the given value isn't listed in
   // the enumeration. The switch still makes sure that all known values are
   // listed here.
   auto known_category = static_cast<KnownCategories>(category.id());
   switch (known_category) {
     case KnownCategories::RECENT_TABS:
       return HistogramCategories::RECENT_TABS;
     case KnownCategories::DOWNLOADS:
       return HistogramCategories::DOWNLOADS;
     case KnownCategories::BOOKMARKS:
       return HistogramCategories::BOOKMARKS;
     case KnownCategories::PHYSICAL_WEB_PAGES:
       return HistogramCategories::PHYSICAL_WEB_PAGES;
     case KnownCategories::FOREIGN_TABS:
       return HistogramCategories::FOREIGN_TABS;
     case KnownCategories::ARTICLES:
       return HistogramCategories::ARTICLES;
     case KnownCategories::READING_LIST:
       return HistogramCategories::READING_LIST;
+    case KnownCategories::BREAKING_NEWS:
+      return HistogramCategories::BREAKING_NEWS;
     case KnownCategories::LOCAL_CATEGORIES_COUNT:
     case KnownCategories::REMOTE_CATEGORIES_OFFSET:
       NOTREACHED();
       return HistogramCategories::COUNT;
   }
   // All other (unknown) categories go into a single "Experimental" bucket.
   return HistogramCategories::EXPERIMENTAL;
 }
 
 // Each suffix here should correspond to an entry under histogram suffix
@@ skipping 10 matching lines @@
     case HistogramCategories::PHYSICAL_WEB_PAGES:
       return "PhysicalWeb";
     case HistogramCategories::FOREIGN_TABS:
       return "ForeignTabs";
     case HistogramCategories::ARTICLES:
       return "Articles";
     case HistogramCategories::EXPERIMENTAL:
       return "Experimental";
     case HistogramCategories::READING_LIST:
       return "ReadingList";
+    case HistogramCategories::BREAKING_NEWS:
+      return "BreakingNews";
     case HistogramCategories::COUNT:
       NOTREACHED();
       break;
   }
   return std::string();
 }
 
 std::string GetCategoryHistogramName(const char* base_name, Category category) {
   return base::StringPrintf(kPerCategoryHistogramFormat, base_name,
                             GetCategorySuffix(category).c_str());
@@ skipping 230 matching lines @@
 void RecordCategoryDismissed() {
   base::RecordAction(base::UserMetricsAction("Suggestions.Category.Dismissed"));
 }
 
 void RecordFetchAction() {
   base::RecordAction(base::UserMetricsAction("Suggestions.Category.Fetch"));
 }
 
 }  // namespace metrics
 }  // namespace ntp_snippets