[NTP::Push] Adding BreakingNewsSuggestionsProvider

components/ntp_snippets/breaking_news/subscription_manager.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/breaking_news/subscription_manager.h"
 #include "base/bind.h"
 #include "components/ntp_snippets/breaking_news/subscription_json_request.h"
+#include "components/ntp_snippets/features.h"
+#include "components/ntp_snippets/ntp_snippets_constants.h"
 #include "components/ntp_snippets/pref_names.h"
 #include "components/prefs/pref_service.h"
+#include "components/variations/variations_associated_data.h"

[jkrcal, 2017/06/09 11:32:59]

please use the new api, instead: 
base/metrics/field_trial_params.h

[mamir, 2017/06/09 14:41:01]

Done.

 
 namespace ntp_snippets {
 
 using internal::SubscriptionJsonRequest;
 
+namespace {
+
+// Variation parameter for chrome-push-subscription backend.
+const char kPushSubscriptionBackend[] = "push_subscription_backend";

[jkrcal, 2017/06/09 11:32:59]

consistency nit: Can you name it kPushSubscriptionBackendParam?
(throughout ntp_snippets field trial param names end with Param)

[mamir, 2017/06/09 14:41:01]

Done.

+
+// Variation parameter for chrome-push-unsubscription backend.
+const char kPushUnsubscriptionBackend[] = "push_unsubscription_backend";

[jkrcal, 2017/06/09 11:32:59]

ditto

[mamir, 2017/06/09 14:41:01]

Done.

+}
+
 SubscriptionManager::SubscriptionManager(
     scoped_refptr<net::URLRequestContextGetter> url_request_context_getter,
     PrefService* pref_service,
     const GURL& subscribe_url,
     const GURL& unsubscribe_url)
     : url_request_context_getter_(std::move(url_request_context_getter)),
       pref_service_(pref_service),
       subscribe_url_(subscribe_url),
       unsubscribe_url_(unsubscribe_url) {}
 
@@ skipping 57 matching lines @@
     default:
       // TODO(mamir): handle failure.
       break;
   }
 }
 
 void SubscriptionManager::RegisterProfilePrefs(PrefRegistrySimple* registry) {
   registry->RegisterStringPref(prefs::kContentSuggestionsSubscriptionDataToken,
                                std::string());
 }
+
+GURL GetPushUpdatesSubscriptionEndpoint(version_info::Channel channel) {
+  std::string endpoint = variations::GetVariationParamValueByFeature(

[jkrcal, 2017/06/09 11:32:59]

Please use the new API with the same parameters:
base::GetFieldTrialParamValueByFeature()

[mamir, 2017/06/09 14:41:01]

Done.

+      ntp_snippets::kContentSuggestionsPushFeature, kPushSubscriptionBackend);
+  if (!endpoint.empty()) {
+    return GURL{endpoint};
+  }
+
+  switch (channel) {
+    case version_info::Channel::STABLE:
+    case version_info::Channel::BETA:
+      return GURL{kPushUpdatesSubscriptionServer};
+
+    case version_info::Channel::DEV:
+    case version_info::Channel::CANARY:
+    case version_info::Channel::UNKNOWN:
+      return GURL{kPushUpdatesSubscriptionStagingServer};
+  }
+  NOTREACHED();
+  return GURL{kPushUpdatesSubscriptionStagingServer};
+}
+
+GURL GetPushUpdatesUnsubscriptionEndpoint(version_info::Channel channel) {
+  std::string endpoint = variations::GetVariationParamValueByFeature(

[jkrcal, 2017/06/09 11:32:59]

ditto

[mamir, 2017/06/09 14:41:01]

Done.

+      ntp_snippets::kContentSuggestionsPushFeature, kPushUnsubscriptionBackend);
+  if (!endpoint.empty()) {
+    return GURL{endpoint};
+  }
+
+  switch (channel) {
+    case version_info::Channel::STABLE:
+    case version_info::Channel::BETA:
+      return GURL{kPushUpdatesUnsubscriptionServer};
+
+    case version_info::Channel::DEV:
+    case version_info::Channel::CANARY:
+    case version_info::Channel::UNKNOWN:
+      return GURL{kPushUpdatesUnsubscriptionStagingServer};
+  }
+  NOTREACHED();
+  return GURL{kPushUpdatesUnsubscriptionStagingServer};
+}
 }  // namespace ntp_snippets