Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: Source/core/frame/DOMWindow.h

Issue 292503006: Oilpan: add [WillBeGarbageCollected] for Node. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add now-required tracing of m_domWindow (oops) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Node.idl ('k') | Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMWindow.h
diff --git a/Source/core/frame/DOMWindow.h b/Source/core/frame/DOMWindow.h
index 4c065e403e66c37169e58cc8bcf05ba79b4c54c8..e69e46f06b64e250d98dd15bb7234ea84c671bf8 100644
--- a/Source/core/frame/DOMWindow.h
+++ b/Source/core/frame/DOMWindow.h
@@ -343,7 +343,19 @@ enum PageshowEventPersistence {
void resetDOMWindowProperties();
void willDestroyDocumentInFrame();
- RefPtr<Document> m_document;
+ // FIXME: Oilpan: the need for this internal method will fall
+ // away when EventTargets are no longer using refcounts and
+ // window properties are also on the heap. Inline the minimal
+ // do-not-broadcast handling then and remove the enum +
+ // removeAllEventListenersInternal().
+ enum BroadcastListenerRemoval {
+ DoNotBroadcastListenerRemoval,
+ DoBroadcastListenerRemoval
+ };
+
+ void removeAllEventListenersInternal(BroadcastListenerRemoval);
+
+ RefPtrWillBeMember<Document> m_document;
bool m_shouldPrintWhenFinishedLoading;
#if ASSERT_ENABLED
« no previous file with comments | « Source/core/dom/Node.idl ('k') | Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698