Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: Source/core/dom/Document.h

Issue 292503006: Oilpan: add [WillBeGarbageCollected] for Node. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add now-required tracing of m_domWindow (oops) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index 9038c277de1b8db6e3e4d50b28f44fbb7a7e930e..fd3d9b2a4511e25ad0edc8064a0bac2f8527b8fb 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -323,8 +323,8 @@ public:
PassRefPtrWillBeRawPtr<ProcessingInstruction> createProcessingInstruction(const String& target, const String& data, ExceptionState&);
PassRefPtrWillBeRawPtr<Attr> createAttribute(const AtomicString& name, ExceptionState&);
PassRefPtrWillBeRawPtr<Attr> createAttributeNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&, bool shouldIgnoreNamespaceChecks = false);
- PassRefPtr<Node> importNode(Node* importedNode, ExceptionState&);
- PassRefPtr<Node> importNode(Node* importedNode, bool deep, ExceptionState&);
+ PassRefPtrWillBeRawPtr<Node> importNode(Node* importedNode, ExceptionState&);
+ PassRefPtrWillBeRawPtr<Node> importNode(Node* importedNode, bool deep, ExceptionState&);
PassRefPtrWillBeRawPtr<Element> createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&);
PassRefPtrWillBeRawPtr<Element> createElement(const QualifiedName&, bool createdByParser);
@@ -686,7 +686,7 @@ public:
void didMergeTextNodes(Text& oldNode, unsigned offset);
void didSplitTextNode(Text& oldNode);
- void clearDOMWindow() { m_domWindow = 0; }
+ void clearDOMWindow() { m_domWindow = nullptr; }
DOMWindow* domWindow() const { return m_domWindow; }
// Helper functions for forwarding DOMWindow event related tasks to the DOMWindow if it exists.
@@ -1192,7 +1192,7 @@ private:
PendingSheetLayout m_pendingSheetLayout;
LocalFrame* m_frame;
- DOMWindow* m_domWindow;
+ RawPtrWillBeMember<DOMWindow> m_domWindow;
HTMLImportsController* m_importsController;
RefPtrWillBeMember<ResourceFetcher> m_fetcher;
« no previous file with comments | « no previous file | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698