Oilpan: add [WillBeGarbageCollected] for Node.

Source/core/dom/Document.h

Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index 9038c277de1b8db6e3e4d50b28f44fbb7a7e930e..1df8aeacf7f4a487927057c7cfe0fca88db24e43 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -323,8 +323,8 @@ public:
     PassRefPtrWillBeRawPtr<ProcessingInstruction> createProcessingInstruction(const String& target, const String& data, ExceptionState&);
     PassRefPtrWillBeRawPtr<Attr> createAttribute(const AtomicString& name, ExceptionState&);
     PassRefPtrWillBeRawPtr<Attr> createAttributeNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&, bool shouldIgnoreNamespaceChecks = false);
-    PassRefPtr<Node> importNode(Node* importedNode, ExceptionState&);
-    PassRefPtr<Node> importNode(Node* importedNode, bool deep, ExceptionState&);
+    PassRefPtrWillBeRawPtr<Node> importNode(Node* importedNode, ExceptionState&);
+    PassRefPtrWillBeRawPtr<Node> importNode(Node* importedNode, bool deep, ExceptionState&);
     PassRefPtrWillBeRawPtr<Element> createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&);
     PassRefPtrWillBeRawPtr<Element> createElement(const QualifiedName&, bool createdByParser);
 
@@ -686,7 +686,7 @@ public:
     void didMergeTextNodes(Text& oldNode, unsigned offset);
     void didSplitTextNode(Text& oldNode);
 
-    void clearDOMWindow() { m_domWindow = 0; }
+    void clearDOMWindow() { m_domWindow = nullptr; }
     DOMWindow* domWindow() const { return m_domWindow; }
 
     // Helper functions for forwarding DOMWindow event related tasks to the DOMWindow if it exists.
@@ -1192,7 +1192,7 @@ private:
     PendingSheetLayout m_pendingSheetLayout;
 
     LocalFrame* m_frame;
-    DOMWindow* m_domWindow;
+    RawPtrWillBeWeakMember<DOMWindow> m_domWindow;

[Mads Ager (chromium), 2014/05/26 06:15:20]

I'm surprised that this isn't a strong pointer instead. A document corresponds
to a DOMWindow until it is explicitly detached from that DOMWindow. When the
explicit detach happens we should perform cleanup and disassociate the two. If
the Document is never detached from the DOMWindow I would expect them to live
and die together and no cleanup would have to happen.

     HTMLImportsController* m_importsController;
 
     RefPtrWillBeMember<ResourceFetcher> m_fetcher;