Source/web/tests/ScrollingCoordinatorChromiumTest.cpp - Issue 292503006: Oilpan: add [WillBeGarbageCollected] for Node.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

Issue 292503006: Oilpan: add [WillBeGarbageCollected] for Node. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix unit test detaching document from window Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

diff --git a/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp b/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

index b870c7348ba736856c3500457bcd8218500612ab..8d150f39ca02aba2613205a5840642c9a3fd41fc 100644

--- a/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

+++ b/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

@@ -258,7 +258,7 @@ TEST_F(ScrollingCoordinatorChromiumTest, updateEventHandlersDuringTeardown)

// Simulate detaching the document from its DOM window. This should not

// cause a crash when the WebViewImpl is closed by the test runner.

- frame()->document()->clearDOMWindow();

+ frame()->document()->prepareForDestruction();

}

TEST_F(ScrollingCoordinatorChromiumTest, clippedBodyTest)

« Source/core/frame/DOMWindow.cpp ('K') | « Source/core/frame/DOMWindow.cpp ('k') | no next file » | no next file with comments »