Oilpan: add [WillBeGarbageCollected] for Node.

Source/core/frame/DOMWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 345 matching lines @@
 }
 
 void DOMWindow::clearEventQueue()
 {
     if (!m_eventQueue)
         return;
     m_eventQueue->close();
     m_eventQueue.clear();
 }
 
-PassRefPtr<Document> DOMWindow::createDocument(const String& mimeType, const DocumentInit& init, bool forceXHTML)
+PassRefPtrWillBeRawPtr<Document> DOMWindow::createDocument(const String& mimeType, const DocumentInit& init, bool forceXHTML)
 {
-    RefPtr<Document> document;
+    RefPtrWillBeRawPtr<Document> document;
     if (forceXHTML) {
         // This is a hack for XSLTProcessor. See XSLTProcessor::createDocumentFromSource().
         document = Document::create(init);
     } else {
         document = DOMImplementation::createDocument(mimeType, init, init.frame() ? init.frame()->inViewSourceMode() : false);
         if (document->isPluginDocument() && document->isSandboxed(SandboxPlugins))
             document = SinkDocument::create(init);
     }
 
     return document.release();
 }
 
-PassRefPtr<Document> DOMWindow::installNewDocument(const String& mimeType, const DocumentInit& init, bool forceXHTML)
+PassRefPtrWillBeRawPtr<Document> DOMWindow::installNewDocument(const String& mimeType, const DocumentInit& init, bool forceXHTML)
 {
     ASSERT(init.frame() == m_frame);
 
     clearDocument();
 
     m_document = createDocument(mimeType, init, forceXHTML);
     m_eventQueue = DOMWindowEventQueue::create(m_document.get());
     m_document->attach();
 
     if (!m_frame)
@@ skipping 87 matching lines @@
         enqueuePopstateEvent(stateObject);
     else
         m_pendingStateObject = stateObject;
 }
 
 DOMWindow::~DOMWindow()
 {
     ASSERT(m_hasBeenReset);
     reset();
 
+#if ENABLE(OILPAN)
+    clearDocument();

[Mads Ager (chromium), 2014/05/23 06:27:29]

Why do we have this call to clearDocument in the oilpan build? We should not be
able to do that. That will access the document which could already have been
destructed. If the DOMWindow and the Document die together hopefully we will not
have to do anything here?

[sof, 2014/05/23 06:32:58]

Oh, clearDocument() not a simple clearing setter. Yes, that's not right.

Stubbing out |m_document| is needed to avoid removeAllEventListeners() from
unregistering touch handlers on the window's document. The document needs to
handle that.

+#endif
     removeAllEventListeners();
 
-#if ENABLE(OILPAN)
-    ASSERT(m_document->isDisposed());
-#else
+#if !ENABLE(OILPAN)
     ASSERT(m_document->isStopped());
+    clearDocument();
 #endif
-
-    clearDocument();
 }
 
 const AtomicString& DOMWindow::interfaceName() const
 {
     return EventTargetNames::DOMWindow;
 }
 
 ExecutionContext* DOMWindow::executionContext() const
 {
     return m_document.get();
@@ skipping 1357 matching lines @@
     return static_cast<DOMWindowLifecycleNotifier&>(LifecycleContext<DOMWindow>::lifecycleNotifier());
 }
 
 PassOwnPtr<LifecycleNotifier<DOMWindow> > DOMWindow::createLifecycleNotifier()
 {
     return DOMWindowLifecycleNotifier::create(this);
 }
 
 void DOMWindow::trace(Visitor* visitor)
 {
+    visitor->trace(m_document);
     visitor->trace(m_screen);
     visitor->trace(m_history);
     visitor->trace(m_locationbar);
     visitor->trace(m_menubar);
     visitor->trace(m_personalbar);
     visitor->trace(m_scrollbars);
     visitor->trace(m_statusbar);
     visitor->trace(m_toolbar);
     visitor->trace(m_console);
     visitor->trace(m_navigator);
     visitor->trace(m_location);
     visitor->trace(m_media);
     visitor->trace(m_sessionStorage);
     visitor->trace(m_localStorage);
     visitor->trace(m_applicationCache);
     visitor->trace(m_performance);
     visitor->trace(m_css);
     WillBeHeapSupplementable<DOMWindow>::trace(visitor);
 }
 
 } // namespace WebCore