Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: Source/core/frame/DOMWindow.h

Issue 292503006: Oilpan: add [WillBeGarbageCollected] for Node. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Tidy up removeAllEventListeners() usage from DOMWindow dtor Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 336
337 Page* page(); 337 Page* page();
338 338
339 virtual void frameDestroyed() OVERRIDE; 339 virtual void frameDestroyed() OVERRIDE;
340 virtual void willDetachFrameHost() OVERRIDE; 340 virtual void willDetachFrameHost() OVERRIDE;
341 341
342 void clearDocument(); 342 void clearDocument();
343 void resetDOMWindowProperties(); 343 void resetDOMWindowProperties();
344 void willDestroyDocumentInFrame(); 344 void willDestroyDocumentInFrame();
345 345
346 RefPtr<Document> m_document; 346 enum BroadcastListenerRemoval {
haraken 2014/05/23 20:53:58 Shall we add a FIXME to remove this? Once we move
sof 2014/05/24 06:53:11 Done.
347 DoNotBroadcastListenerRemoval,
348 DoBroadcastListenerRemoval
349 };
350
351 void removeAllEventListeners(BroadcastListenerRemoval);
haraken 2014/05/23 20:53:58 It's a bit confusing to have the overridden versio
sof 2014/05/24 06:53:11 Done.
352
353 RefPtrWillBeMember<Document> m_document;
347 354
348 bool m_shouldPrintWhenFinishedLoading; 355 bool m_shouldPrintWhenFinishedLoading;
349 #if ASSERT_ENABLED 356 #if ASSERT_ENABLED
350 bool m_hasBeenReset; 357 bool m_hasBeenReset;
351 #endif 358 #endif
352 359
353 HashSet<DOMWindowProperty*> m_properties; 360 HashSet<DOMWindowProperty*> m_properties;
354 361
355 mutable RefPtrWillBeMember<Screen> m_screen; 362 mutable RefPtrWillBeMember<Screen> m_screen;
356 mutable RefPtrWillBeMember<History> m_history; 363 mutable RefPtrWillBeMember<History> m_history;
(...skipping 29 matching lines...) Expand all
386 } 393 }
387 394
388 inline String DOMWindow::defaultStatus() const 395 inline String DOMWindow::defaultStatus() const
389 { 396 {
390 return m_defaultStatus; 397 return m_defaultStatus;
391 } 398 }
392 399
393 } // namespace WebCore 400 } // namespace WebCore
394 401
395 #endif // DOMWindow_h 402 #endif // DOMWindow_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698