Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: components/variations/variations_seed_simulator.cc

Issue 2924983003: [Variations] Refactor all state used for study filtering into a container struct. (Closed)
Patch Set: A bit more cleanup Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/variations_seed_simulator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/variations_seed_simulator.cc
diff --git a/components/variations/variations_seed_simulator.cc b/components/variations/variations_seed_simulator.cc
index 59b56643adf1d94a8d78d82963a9ec923a30d583..05f5f73ebd24db653f173e997222935abcb27af4 100644
--- a/components/variations/variations_seed_simulator.cc
+++ b/components/variations/variations_seed_simulator.cc
@@ -9,6 +9,7 @@
#include <map>
#include "base/metrics/field_trial.h"
+#include "components/variations/client_filterable_state.h"
#include "components/variations/processed_study.h"
#include "components/variations/proto/study.pb.h"
#include "components/variations/study_filtering.h"
@@ -114,19 +115,9 @@ VariationsSeedSimulator::~VariationsSeedSimulator() {
VariationsSeedSimulator::Result VariationsSeedSimulator::SimulateSeedStudies(
const VariationsSeed& seed,
- const std::string& locale,
- const base::Time& reference_date,
- const base::Version& version,
- Study_Channel channel,
- Study_FormFactor form_factor,
- const std::string& hardware_class,
- const std::string& session_consistency_country,
- const std::string& permanent_consistency_country) {
+ const ClientFilterableState& client_state) {
std::vector<ProcessedStudy> filtered_studies;
- FilterAndValidateStudies(seed, locale, reference_date, version, channel,
- form_factor, hardware_class,
- session_consistency_country,
- permanent_consistency_country, &filtered_studies);
+ FilterAndValidateStudies(seed, client_state, &filtered_studies);
return ComputeDifferences(filtered_studies);
}
« no previous file with comments | « components/variations/variations_seed_simulator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698