Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: components/variations/variations_seed_processor.cc

Issue 2924983003: [Variations] Refactor all state used for study filtering into a container struct. (Closed)
Patch Set: A bit more cleanup Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_seed_processor.cc
diff --git a/components/variations/variations_seed_processor.cc b/components/variations/variations_seed_processor.cc
index c1bb22f5762577aa305ac5f06eafbcf13e33255c..9ac9388f1e3a4983a1c662626d1251f1b8f640f6 100644
--- a/components/variations/variations_seed_processor.cc
+++ b/components/variations/variations_seed_processor.cc
@@ -14,6 +14,7 @@
#include "base/metrics/field_trial.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/utf_string_conversions.h"
+#include "components/variations/client_filterable_state.h"
#include "components/variations/processed_study.h"
#include "components/variations/study_filtering.h"
#include "components/variations/variations_associated_data.h"
@@ -175,26 +176,17 @@ VariationsSeedProcessor::~VariationsSeedProcessor() {
void VariationsSeedProcessor::CreateTrialsFromSeed(
const VariationsSeed& seed,
- const std::string& locale,
- const base::Time& reference_date,
- const base::Version& version,
- Study_Channel channel,
- Study_FormFactor form_factor,
- const std::string& hardware_class,
- const std::string& session_consistency_country,
- const std::string& permanent_consistency_country,
+ const ClientFilterableState& client_state,
const UIStringOverrideCallback& override_callback,
const base::FieldTrial::EntropyProvider* low_entropy_provider,
base::FeatureList* feature_list) {
std::vector<ProcessedStudy> filtered_studies;
- FilterAndValidateStudies(seed, locale, reference_date, version, channel,
- form_factor, hardware_class,
- session_consistency_country,
- permanent_consistency_country, &filtered_studies);
-
- for (size_t i = 0; i < filtered_studies.size(); ++i)
- CreateTrialFromStudy(filtered_studies[i], override_callback,
- low_entropy_provider, feature_list);
+ FilterAndValidateStudies(seed, client_state, &filtered_studies);
+
+ for (const ProcessedStudy& study : filtered_studies) {
+ CreateTrialFromStudy(study, override_callback, low_entropy_provider,
+ feature_list);
+ }
}
// static
« no previous file with comments | « components/variations/variations_seed_processor.h ('k') | components/variations/variations_seed_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698