Issue 2924943005: Make a copy of files to invalidate to avoid concurrent modifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2924943005: Make a copy of files to invalidate to avoid concurrent modifications. (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Make a copy of files to invalidate to avoid concurrent modifications. In contrast to Analysis Driver, in Kernel Driver FileState.refresh() is asynchronous, so we might (and actually do) get concurrent watch events that update the set of invalidate files. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c510737b17c9bd72db6ce30909b85d618326fe4a

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	pkg/front_end/lib/src/incremental_kernel_generator_impl.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as c510737b17c9bd72db6ce30909b85d618326fe4a (presubmit successful).

3 years, 6 months ago (2017-06-07 18:10:56 UTC) #4

Message was sent while issue was closed.

lgtm