Issue 292493002: Update didClearWindowObject API in webview plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292493002: Update didClearWindowObject API in webview plugin (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update didClearWindowObject API in webview plugin We now only call this method for the main world (world_id == 0) BUG=none R=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270998

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	components/plugins/renderer/webview_plugin.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	components/plugins/renderer/webview_plugin.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

jochen (gone - plz use gerrit)

The CQ bit was checked by jochen@chromium.org

6 years, 7 months ago (2014-05-16 08:43:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/292493002/1

6 years, 7 months ago (2014-05-16 08:44:11 UTC) #4

Message was sent while issue was closed.

Change committed as 270998