Don't activate aura::Window on creation from DesktopNativeWidgetAura if NativeWidgetDelegate prohib…

ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/trace_event/trace_event.h"
@@ skipping 482 matching lines @@
   host_->window()->AddPreTargetHandler(focus_controller);
 
   position_client_.reset(new DesktopScreenPositionClient(host_->window()));
 
   drag_drop_client_ = desktop_window_tree_host_->CreateDragDropClient(
       native_cursor_manager_);
   // Mus returns null from CreateDragDropClient().
   if (drag_drop_client_)
     aura::client::SetDragDropClient(host_->window(), drag_drop_client_.get());
 
-  static_cast<aura::client::FocusClient*>(focus_client_.get())->

[sky, 2017/06/08 19:45:32]

Shouldn't this code still focus the window for the CanActivate case?

[vasilii, 2017/06/09 12:36:45]

Done. Moved the call despite I don't see the place between #503 and #540 that
cares about focus.

-      FocusWindow(content_window_);
-
   OnHostResized(host());
 
   host_->AddObserver(this);
 
   window_parenting_client_.reset(
       new DesktopNativeWidgetAuraWindowParentingClient(host_->window()));
   drop_helper_.reset(new DropHelper(GetWidget()->GetRootView()));
   aura::client::SetDragDropDelegate(content_window_, this);
 
   if (params.type != Widget::InitParams::TYPE_TOOLTIP) {
@@ skipping 14 matching lines @@
   }
 
   if (params.type == Widget::InitParams::TYPE_WINDOW) {
     focus_manager_event_handler_ = base::MakeUnique<FocusManagerEventHandler>(
         GetWidget(), host_->window());
   }
 
   event_client_.reset(new DesktopEventClient);
   aura::client::SetEventClient(host_->window(), event_client_.get());
 
+  wm::SetActivationDelegate(content_window_, this);
   aura::client::GetFocusClient(content_window_)->FocusWindow(content_window_);
 
-  wm::SetActivationDelegate(content_window_, this);
-
   shadow_controller_.reset(
       new wm::ShadowController(wm::GetActivationClient(host_->window())));
 
   OnSizeConstraintsChanged();
 
   window_reorderer_.reset(new WindowReorderer(content_window_,
       GetWidget()->GetRootView()));
 }
 
 void DesktopNativeWidgetAura::OnWidgetInitDone() {
@@ skipping 658 matching lines @@
   if (cursor_reference_count_ == 0) {
     // We are the last DesktopNativeWidgetAura instance, and we are responsible
     // for cleaning up |cursor_manager_|.
     delete cursor_manager_;
     native_cursor_manager_ = NULL;
     cursor_manager_ = NULL;
   }
 }
 
 }  // namespace views