Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 2924853003: Fix implementation of fold() in analyzer's mock SDK. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M pkg/analyzer/test/src/context/mock_sdk.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_downwards_inference_fold.dart View 2 chunks +7 lines, -5 lines 0 comments Download
A pkg/front_end/testcases/inference/generic_methods_downwards_inference_fold.dart.strong.expect View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-06 20:20:44 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-06 20:22:59 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-06 20:23:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49110ba0d67dbb20262a5df1c7c1f562d185fa1f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698