Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: pkg/front_end/lib/src/fasta/fasta.dart

Issue 2924833002: Pass a Target instance to DillTarget instead of its name (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/fasta.dart
diff --git a/pkg/front_end/lib/src/fasta/fasta.dart b/pkg/front_end/lib/src/fasta/fasta.dart
index c0ec047be289e11c6bcd003874dbf0d93a1a50fc..4fe007100ac12c728f44690c02dee457e9496201 100644
--- a/pkg/front_end/lib/src/fasta/fasta.dart
+++ b/pkg/front_end/lib/src/fasta/fasta.dart
@@ -18,7 +18,7 @@ import 'package:kernel/binary/ast_to_binary.dart'
import 'package:kernel/kernel.dart' show Library, Program, loadProgramFromBytes;
-import 'package:kernel/target/targets.dart' show TargetFlags;
+import 'package:kernel/target/targets.dart' show getTarget, TargetFlags;
import 'compiler_command_line.dart' show CompilerCommandLine;
@@ -114,8 +114,11 @@ class CompileTask {
CompileTask(this.c, this.ticker);
DillTarget createDillTarget(TranslateUri uriTranslator) {
- return new DillTarget(ticker, uriTranslator, c.options.target,
- flags: new TargetFlags(strongMode: c.options.strongMode));
+ return new DillTarget(
+ ticker,
+ uriTranslator,
+ getTarget(c.options.target,
ahe 2017/06/06 14:02:37 Perhaps we should move this to compiler_options.da
Dmitry Stefantsov 2017/06/06 14:13:26 Sorry for missing it again XD I'll be more careful
+ new TargetFlags(strongMode: c.options.strongMode)));
}
KernelTarget createKernelTarget(
@@ -199,9 +202,8 @@ Future<CompilationResult> parseScriptInFileSystem(
TranslateUri uriTranslator =
await TranslateUri.parse(fileSystem, patchedSdk, packages: packages);
final Ticker ticker = new Ticker(isVerbose: verbose);
- final DillTarget dillTarget = new DillTarget(
- ticker, uriTranslator, backendTarget,
- flags: new TargetFlags(strongMode: strongMode));
+ final DillTarget dillTarget = new DillTarget(ticker, uriTranslator,
+ getTarget(backendTarget, new TargetFlags(strongMode: strongMode)));
_appendDillForUri(dillTarget, patchedSdk.resolve('platform.dill'));
final KernelTarget kernelTarget =
new KernelTarget(fileSystem, dillTarget, uriTranslator);
@@ -275,8 +277,8 @@ Future writeDepsFile(Uri script, Uri depsFile, Uri output,
TranslateUri uriTranslator = await TranslateUri.parse(c.fileSystem, sdk,
packages: c.options.packages);
ticker.logMs("Read packages file");
- DillTarget dillTarget = new DillTarget(ticker, uriTranslator, backendTarget,
- flags: new TargetFlags(strongMode: false));
+ DillTarget dillTarget = new DillTarget(ticker, uriTranslator,
+ getTarget(backendTarget, new TargetFlags(strongMode: false)));
_appendDillForUri(dillTarget, platform);
KernelTarget kernelTarget = new KernelTarget(
PhysicalFileSystem.instance, dillTarget, uriTranslator, c.uriToSource);
« no previous file with comments | « pkg/front_end/lib/src/fasta/dill/dill_target.dart ('k') | pkg/front_end/lib/src/incremental_kernel_generator_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698