Issue 2924803002: Avoid using FunctionSignature in builder_kernel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2924803002: Avoid using FunctionSignature in builder_kernel (Closed)

Created:
3 years, 6 months ago by Johnni Winther

Modified:
3 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, Emily Fortuna

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -71 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	3 chunks	+10 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map.dart	View	2 chunks	+13 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View	9 chunks	+59 lines, -53 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/locals_handler.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 6 months ago (2017-06-07 08:09:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f538506e6d2207ed3be6e650beba10879424e1c4 (presubmit successful).