Network service: SafeBrowsing check for frame-resources from browser.

chrome/browser/safe_browsing/safe_browsing_browser_throttle.cc

Index: chrome/browser/safe_browsing/safe_browsing_browser_throttle.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_browser_throttle.cc b/chrome/browser/safe_browsing/safe_browsing_browser_throttle.cc
new file mode 100644
index 0000000000000000000000000000000000000000..843f0982d5a586de05ea0ed89f0606013105bdeb
--- /dev/null
+++ b/chrome/browser/safe_browsing/safe_browsing_browser_throttle.cc
@@ -0,0 +1,89 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_browsing/safe_browsing_browser_throttle.h"
+
+#include "base/logging.h"
+#include "chrome/browser/safe_browsing/safe_browsing_url_checker_impl.h"
+#include "chrome/browser/safe_browsing/ui_manager.h"
+#include "components/safe_browsing_db/database_manager.h"
+#include "net/url_request/redirect_info.h"
+
+namespace safe_browsing {
+
+SafeBrowsingBrowserThrottle::SafeBrowsingBrowserThrottle(
+    scoped_refptr<SafeBrowsingDatabaseManager> database_manager,
+    scoped_refptr<SafeBrowsingUIManager> ui_manager,
+    const base::Callback<content::WebContents*()>& web_contents_getter)
+    : database_manager_(database_manager),
+      ui_manager_(ui_manager),
+      web_contents_getter_(web_contents_getter) {}
+
+SafeBrowsingBrowserThrottle::~SafeBrowsingBrowserThrottle() {
+  during_destruction_ = true;

[vakh (use Gerrit instead), 2017/06/15 21:52:58]

What's the use of setting this flag in the ~?
Once the object is destructed, this flag shouldn't be read anyway so its vale
shouldn't matter.

[yzshen1, 2017/06/16 21:27:09]

Because destruction of the SafeBrowsingUrlCheckerImpl this object owns will call
SafeBrowsingBrowserThrottle::OnCheckUrlResult(). In this case, we want
OnCheckUrlResult to be a no-op. Otherwise it will try to make virtual calls with
|delegate_| and crash.

I have made changes to SafeBrowsingUrlCheckerImpl's destruction behavior and
removed this boolean.

+}
+
+void SafeBrowsingBrowserThrottle::WillStartRequest(
+    const GURL& url,
+    int load_flags,
+    content::ResourceType resource_type,
+    bool* defer) {
+  DCHECK_EQ(0u, pending_checks_);
+  DCHECK(!blocked_);
+  DCHECK(!url_checker_);
+
+  pending_checks_++;
+  url_checker_ = base::MakeUnique<SafeBrowsingUrlCheckerImpl>(
+      load_flags, resource_type, std::move(database_manager_),
+      std::move(ui_manager_), web_contents_getter_);
+  url_checker_->CheckUrl(
+      url, base::Bind(&SafeBrowsingBrowserThrottle::OnCheckUrlResult,
+                      base::Unretained(this)));
+}
+
+void SafeBrowsingBrowserThrottle::WillRedirectRequest(
+    const net::RedirectInfo& redirect_info,
+    bool* defer) {
+  // If |blocked_| is true, the resource load has been canceled and there
+  // shouldn't be such a notification.
+  DCHECK(!blocked_);
+
+  pending_checks_++;
+  url_checker_->CheckUrl(
+      redirect_info.new_url,
+      base::BindOnce(&SafeBrowsingBrowserThrottle::OnCheckUrlResult,
+                     base::Unretained(this)));
+}
+
+void SafeBrowsingBrowserThrottle::WillProcessResponse(bool* defer) {
+  // If |blocked_| is true, the resource load has been canceled and there
+  // shouldn't be such a notification.
+  DCHECK(!blocked_);
+
+  if (pending_checks_ > 0)
+    *defer = true;
+}
+
+void SafeBrowsingBrowserThrottle::OnCheckUrlResult(bool safe) {
+  if (blocked_ || during_destruction_)
+    return;
+
+  DCHECK_LT(0u, pending_checks_);
+  pending_checks_--;
+
+  if (safe) {
+    if (pending_checks_ == 0) {
+      // The resource load is not necessarily deferred, in that case Resume() is
+      // a no-op.
+      delegate_->Resume();
+    }
+  } else {
+    url_checker_.reset();
+    blocked_ = true;
+    pending_checks_ = 0;
+    delegate_->CancelWithError(net::ERR_ABORTED);
+  }
+}
+
+}  // namespace safe_browsing