Network service: SafeBrowsing check for frame-resources from browser.

chrome/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 1166 matching lines @@
     "safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.cc",
     "safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h",
     "safe_browsing/chrome_cleaner/srt_client_info_win.cc",
     "safe_browsing/chrome_cleaner/srt_client_info_win.h",
     "safe_browsing/chrome_cleaner/srt_field_trial_win.cc",
     "safe_browsing/chrome_cleaner/srt_field_trial_win.h",
     "safe_browsing/chrome_cleaner/srt_global_error_win.cc",
     "safe_browsing/chrome_cleaner/srt_global_error_win.h",
     "safe_browsing/mojo_safe_browsing_impl.cc",
     "safe_browsing/mojo_safe_browsing_impl.h",
+    "safe_browsing/safe_browsing_browser_throttle.cc",

[vakh (use Gerrit instead), 2017/06/15 21:52:58]

Could you please create a target for these files in
chrome/browser/safe_browsing/BUILD.gn and add those targets as DEPS here?

I know you are following precedent, but the sooner we start doing it correctly,
the better.

[yzshen1, 2017/06/16 21:27:09]

I feel that the current CL is already big and this is a relatively orthogonal
change. Do you mind if I put it in a separate CL?
I gave it a try but it moved quite a lot of lines and also I met some build
issues that I need to figure out.

+    "safe_browsing/safe_browsing_browser_throttle.h",
     "safe_browsing/safe_browsing_tab_observer.cc",
     "safe_browsing/safe_browsing_tab_observer.h",
+    "safe_browsing/safe_browsing_url_checker_impl.cc",
+    "safe_browsing/safe_browsing_url_checker_impl.h",
     "safe_search_api/safe_search_url_checker.cc",
     "safe_search_api/safe_search_url_checker.h",
     "search/iframe_source.cc",
     "search/iframe_source.h",
     "search/instant_io_context.cc",
     "search/instant_io_context.h",
     "search/instant_service.cc",
     "search/instant_service.h",
     "search/instant_service_factory.cc",
     "search/instant_service_factory.h",
@@ skipping 3584 matching lines @@
       "//components/search_engines",
       "//rlz:rlz_lib",
     ]
   }
 }
 
 service_manifest("preferences_forwarder_manifest") {
   name = "preferences_forwarder"
   source = "prefs/forwarder_manifest.json"
 }