Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2924703002: Move CompletionTarget and OpType for use by plugins (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3840 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 1 chunk +0 lines, -455 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 2 chunks +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 1 chunk +0 lines, -980 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/override_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 chunk +0 lines, -601 lines 0 comments Download
D pkg/analysis_server/test/services/completion/dart/optype_test.dart View 1 chunk +0 lines, -1739 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
A + pkg/analyzer_plugin/lib/src/utilities/completion/completion_target.dart View 3 chunks +28 lines, -28 lines 0 comments Download
A + pkg/analyzer_plugin/lib/src/utilities/completion/optype.dart View 6 chunks +8 lines, -4 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/completion/completion_target_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/completion/optype_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/completion/test_all.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
More support classes used by the completion contributors that need to be moved.
3 years, 6 months ago (2017-06-05 21:15:01 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-05 21:31:58 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-06 14:07:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
db0a8a76aea2c7f63a9cda5cacfcf2d33dfd5a3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698