Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2924693003: Entity-ify some portions of LocalsHandler and Closure. (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -26 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 6 chunks +7 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 5 chunks +6 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Emily Fortuna
Chipping of small pieces of this super-CL I have locally!
3 years, 6 months ago (2017-06-06 01:30:50 UTC) #3
Emily Fortuna
On 2017/06/06 01:30:50, Emily Fortuna wrote: > Chipping of small pieces of this super-CL I ...
3 years, 6 months ago (2017-06-06 01:31:01 UTC) #4
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2924693003/diff/20001/pkg/compiler/lib/src/closure.dart File pkg/compiler/lib/src/closure.dart (right): https://codereview.chromium.org/2924693003/diff/20001/pkg/compiler/lib/src/closure.dart#newcode136 pkg/compiler/lib/src/closure.dart:136: abstract class CapturedVariable implements Element {} I wonder ...
3 years, 6 months ago (2017-06-06 03:07:36 UTC) #6
Johnni Winther
lgtm
3 years, 6 months ago (2017-06-06 07:43:38 UTC) #7
Emily Fortuna
https://codereview.chromium.org/2924693003/diff/20001/pkg/compiler/lib/src/closure.dart File pkg/compiler/lib/src/closure.dart (right): https://codereview.chromium.org/2924693003/diff/20001/pkg/compiler/lib/src/closure.dart#newcode136 pkg/compiler/lib/src/closure.dart:136: abstract class CapturedVariable implements Element {} On 2017/06/06 03:07:36, ...
3 years, 6 months ago (2017-06-06 17:46:20 UTC) #8
Emily Fortuna
3 years, 6 months ago (2017-06-06 17:53:19 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:10003) manually as
03572798ff52f4e626d2fc5f40e13c3daf9999fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698