chrome/test/data/extensions/api_test/bindings/event_filter/background.js - Issue 2924683002: [Extensions Bindings] Avoid passing the event filter to JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/bindings/event_filter/background.js

Issue 2924683002: [Extensions Bindings] Avoid passing the event filter to JS (Closed)

Patch Set: remove extra '.' Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_bindings_apitest.cc ('k') | chrome/test/data/extensions/api_test/bindings/event_filter/manifest.json » ('j') | extensions/renderer/event_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/bindings/event_filter/background.js

diff --git a/chrome/test/data/extensions/api_test/bindings/event_filter/background.js b/chrome/test/data/extensions/api_test/bindings/event_filter/background.js

new file mode 100644

index 0000000000000000000000000000000000000000..f45a74bafcc9855628e2d76c98e80d21dddb2b46

--- /dev/null

+++ b/chrome/test/data/extensions/api_test/bindings/event_filter/background.js

@@ -0,0 +1,11 @@

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+Object.defineProperty(Object.prototype, 'windowExposedByDefault',

lazyboy 2017/06/10 00:22:08 nit: put a comment about the intent of this custom

Devlin 2017/06/12 17:01:54 Done.

+ {enumerable: true, get() { return 'hahaha'; }});

lazyboy 2017/06/10 00:22:08 nit: remove one of the two spaces before "return"

Devlin 2017/06/12 17:01:54 Good catch! Done.

+chrome.webNavigation.onBeforeNavigate.addListener(function() {

+ chrome.test.notifyPass();

+}, {url: [{hostContains: 'example.com'}]});

+chrome.test.sendMessage('ready');