Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: tools/perf/page_sets/oopif_basic_page_set.py

Issue 2924623002: Explicitly setting names for story sets in page_cycler_v2 benchmarks (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import cache_temperature as cache_temperature_module 4 from telemetry.page import cache_temperature as cache_temperature_module
5 from telemetry.page import page 5 from telemetry.page import page
6 from telemetry import story 6 from telemetry import story
7 7
8 class OopifBasicPageSet(story.StorySet): 8 class OopifBasicPageSet(story.StorySet):
9 """ Basic set of pages used to measure performance of out-of-process 9 """ Basic set of pages used to measure performance of out-of-process
10 iframes. 10 iframes.
11 """ 11 """
12 12
13 def __init__(self, cache_temperatures=None): 13 def __init__(self, cache_temperatures=None):
14 super(OopifBasicPageSet, self).__init__( 14 super(OopifBasicPageSet, self).__init__(
15 archive_data_file='data/oopif_basic.json', 15 archive_data_file='data/oopif_basic.json',
16 cloud_storage_bucket=story.PARTNER_BUCKET) 16 cloud_storage_bucket=story.PARTNER_BUCKET,
17 verify_names=True)
17 if cache_temperatures is None: 18 if cache_temperatures is None:
18 cache_temperatures = [cache_temperature_module.ANY] 19 cache_temperatures = [cache_temperature_module.ANY]
19 20
20 urls = [ 21 urls = [
21 'http://www.cnn.com', 22 'http://www.cnn.com',
22 'http://www.ebay.com', 23 'http://www.ebay.com',
23 'http://booking.com', 24 'http://booking.com',
24 # Disabled because it causes flaky runs https://crbug.com/522870 25 # Disabled because it causes flaky runs https://crbug.com/522870
25 #'http://www.rei.com/', 26 #'http://www.rei.com/',
26 'http://www.fifa.com/', 27 'http://www.fifa.com/',
27 # Disabled because it is flaky on Windows and Android 28 # Disabled because it is flaky on Windows and Android
28 #'http://arstechnica.com/', 29 #'http://arstechnica.com/',
29 'http://www.nationalgeographic.com/', 30 'http://www.nationalgeographic.com/',
30 # Cross-site heavy! Enable them once they render without crashing. 31 # Cross-site heavy! Enable them once they render without crashing.
31 #'http://www.nba.com/', 32 #'http://www.nba.com/',
32 #'http://www.phonearena.com/', 33 #'http://www.phonearena.com/',
33 #'http://slickdeals.net/', 34 #'http://slickdeals.net/',
34 #'http://www.163.com/', 35 #'http://www.163.com/',
35 ] 36 ]
36 37
37 for url in urls: 38 for url in urls:
38 for temp in cache_temperatures: 39 for temp in cache_temperatures:
39 self.AddStory(page.Page(url, self, cache_temperature=temp)) 40 self.AddStory(page.Page(url, self, cache_temperature=temp, name=url))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698